Wuzzy/Repixture
6
33
Fork
You've already forked Repixture
10

Modifications to Liquid Textures #172

Closed
TPH wants to merge 6 commits from TPH/Repixture:liquids into master
pull from: TPH/Repixture:liquids
merge into: Wuzzy:master
Wuzzy:master
Wuzzy:new_weather_types
Wuzzy:clock
Wuzzy:sponge
Wuzzy:cushion
Wuzzy:vase
Wuzzy:pages
Wuzzy:giant_crops
Wuzzy:duckweed
Wuzzy:new_hairs_new_skin_selection
Wuzzy:new_hairs
Wuzzy:multi_flower_2
Wuzzy:dirt_redo
Wuzzy:craft_compat
Wuzzy:gold_coin_upgrade
Wuzzy:gold_coin
Wuzzy:new_traders
Wuzzy:item_frame_flat
Wuzzy:silktouch_paint
Wuzzy:silktouch
Wuzzy:newtrees
Wuzzy:new_weather
Wuzzy:creative_per_player
Wuzzy:scrollbar_style
Wuzzy:village_nextgen_thread
Wuzzy:village_nextgen
Wuzzy:new_website
Wuzzy:tnt_faster
Wuzzy:fixbrush
Wuzzy:roots
Wuzzy:amber_slime
Wuzzy:fir
Wuzzy:path_fixes
Wuzzy:villager_pathfind_cost
Wuzzy:fence_gate
Wuzzy:slab_up
Wuzzy:biome_skies
Wuzzy:pencil_showlabel
Wuzzy:moonflower_seed
Wuzzy:unicode_signs_refactor_newsigns_sideways
Wuzzy:unicode_signs
Wuzzy:spyglass
Wuzzy:craftcolor
Wuzzy:villager_pathfind
Wuzzy:mobs_new2
Wuzzy:paint_book
Wuzzy:moon_phases
Wuzzy:newmusic
Wuzzy:weblate_test
Wuzzy:paint4dir
Wuzzy:whistle
Wuzzy:buoy
Wuzzy:pot
Wuzzy:4x4grass
Wuzzy:village_vmanip
Wuzzy:seagrass
First-time contributor
Copy link

As the name implies :D

I also shave 16kb+ so far off of the download size by using texture modifiers instead of a separate texture file for each node. Barely any or no difference in colour or opacity noted between the old and new textures.

I have "WIP" set up as I think I'll try modifying the inventory images as well.

As the name implies :D I also shave 16kb+ so far off of the download size by using texture modifiers instead of a separate texture file for each node. Barely any or no difference in colour or opacity noted between the old and new textures. I have "WIP" set up as I think I'll try modifying the inventory images as well.
Author
First-time contributor
Copy link

There, another 14.2kb shaved off :D

There, another 14.2kb shaved off :D
Author
First-time contributor
Copy link

I license this content either under you or your game's license, or if that's not applicable, CC0 1.0 ;p

I don't consider the changes I did to code licensable as it really was just simple lol

I license this content either under you or your game's license, or if that's not applicable, CC0 1.0 ;p I don't consider the changes I did to code licensable as it really was just simple lol
TPH changed title from (削除) WIP: Modifications to Liquid Textures (削除ここまで) to Modifications to Liquid Textures 2024年04月20日 17:16:15 +02:00
Author
First-time contributor
Copy link

Water node animations: 17.4kb --> 1.2kb

Water inventory images: 14.4kb --> 193 bytes

Water node animations: 17.4kb --> 1.2kb Water inventory images: 14.4kb --> 193 bytes
Owner
Copy link

It is intentional that separate textures are used for each water. It is also intentional that no texture modifiers are used. The reason is to give maximum freedom to texture pack creators.

I only accept MRs that follow this principle. Sorry, I'm very strict about these things in Repixture.

It is intentional that separate textures are used for each water. It is also intentional that no texture modifiers are used. The reason is to give maximum freedom to texture pack creators. I only accept MRs that follow this principle. Sorry, I'm very strict about these things in Repixture.
Author
First-time contributor
Copy link

Ah ok :o I'll fix that then

Ah ok :o I'll fix that then
TPH changed title from (削除) Modifications to Liquid Textures (削除ここまで) to WIP: Modifications to Liquid Textures 2024年04月20日 18:49:51 +02:00
TPH changed title from (削除) WIP: Modifications to Liquid Textures (削除ここまで) to Modifications to Liquid Textures 2024年04月20日 19:00:57 +02:00
Author
First-time contributor
Copy link

Alright, fixed it ;p

Alright, fixed it ;p
Owner
Copy link

I finally got around to give this a try and ... Sorry, I don't really like it.
There are more animation frames, yes, but the animation seems to have a clear "flowing" direction, even if slow. This is not how water sources should behave IMHO.

I finally got around to give this a try and ... Sorry, I don't really like it. There are more animation frames, yes, but the animation seems to have a clear "flowing" direction, even if slow. This is not how water sources should behave IMHO.
Author
First-time contributor
Copy link

FAIRRRR good point
I'll give it another try soon

FAIRRRR good point I'll give it another try soon
Owner
Copy link

I'm going to close this in about 1 week if nothing happens. (sorry)

I'm going to close this in about 1 week if nothing happens. (sorry)
Wuzzy added the due date 2024年06月03日 2024年05月27日 13:48:17 +02:00
Author
First-time contributor
Copy link

Fair 'nough, de-polluting. I'll see if get back to this before so

Fair 'nough, de-polluting. I'll see if get back to this before so
Author
First-time contributor
Copy link

Changed it :D

Changed it :D
Owner
Copy link

Hmmm, sorry but I don't really like the new one either. The animation looks too busy and chaotic now. It's more like a portal than a liquid surface. I simply like the current animation more.

Thanks for your effort but I made a decision: I ultimately reject this. Sorry, my quality standards for this game are high. :P

I guess I rather do this myself then. Oh, and I forgot to mention this, I want to increase the texture size to ×ばつ64, spanning over ×ばつ4 nodes (like for the grass cover) so it doesn't look that repetitive anymore. (I would still have accepted a good ×ばつ16 anim.) I haven't tested if this texture mode works on liquids tho.

For future PRs, I suggest to first discuss in an issue before starting the work to avoid it going to waste.

Hmmm, sorry but I don't really like the new one either. The animation looks too busy and chaotic now. It's more like a portal than a liquid surface. I simply like the current animation more. Thanks for your effort but I made a decision: I ultimately reject this. Sorry, my quality standards for this game are high. :P I guess I rather do this myself then. Oh, and I forgot to mention this, I want to increase the texture size to ×ばつ64, spanning over ×ばつ4 nodes (like for the grass cover) so it doesn't look that repetitive anymore. (I would still have accepted a good ×ばつ16 anim.) I haven't tested if this texture mode works on liquids tho. For future PRs, I suggest to first discuss in an issue before starting the work to avoid it going to waste.
Wuzzy closed this pull request 2024年06月01日 09:13:42 +02:00
Author
First-time contributor
Copy link

Ooooh increase to 64x64? ;o
Oh wait I see what you mean ohhh

Ooooh increase to 64x64? ;o Oh wait I see what you mean ohhh

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
No reviewers
Labels
Clear labels
Category: Discussion
For discussions about the game
Category: Entities
About entities or objects (including player)
Category: Gameplay
About gameplay mechanics in general
Category: Graphics
About graphics
Category: GUI and HUD
Anything related to the graphical user interface or heads-up display
Category: Items and Tools
About items or tools, but not nodes
Category: Mapgen
About the map generator
Category: Nodes
About nodes
Category: Sounds
About sounds
Category: Translation
About translations
Category: Website
Related to the Repixture website
Kind
Balancing
 About game balance
Kind
Bug
 When something doesn't work right
Kind
Documentation
 About documentation, both for devs and players
Kind
Feature
 Ideas, feature requests, enhancements, etc.
Kind
Maintenance
 Code quality, technical improvements, refactoring, etc.
Kind
Performance
 About making the game run fast
Priority
CRITICAL
 Highest priority level. For crashes, major data loss, etc.
Priority
High
 The priority is high
Priority
Low
 The priority is low
Priority
Medium
 The priority is medium
Reviewed
Decision needed
 When the issue still needs a decision on what to do
Reviewed
Duplicate
 When the issue existed already
Reviewed
Invalid
 When the issue was not valid
Reviewed
Rejected
 When something that was proposed was rejected
Status
Needs engine change
 When it can only be solved after a Luanti bugfix/improvement
Status
Needs testing
 If the task is believed to be done, but needs testing
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

2024年06月04日

Dependencies

No dependencies set.

Reference
Wuzzy/Repixture!172
Reference in a new issue
Wuzzy/Repixture
No description provided.
Delete branch "TPH/Repixture:liquids"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?