Wuzzy/Repixture
6
33
Fork
You've already forked Repixture
10

Add support for Visual Harm 1ndicators mod #151

Closed
Mantar wants to merge 1 commit from Mantar/Repixture:VH1_support into master
pull from: Mantar/Repixture:VH1_support
merge into: Wuzzy:master
Wuzzy:master
Wuzzy:new_weather_types
Wuzzy:clock
Wuzzy:sponge
Wuzzy:cushion
Wuzzy:vase
Wuzzy:pages
Wuzzy:giant_crops
Wuzzy:duckweed
Wuzzy:new_hairs_new_skin_selection
Wuzzy:new_hairs
Wuzzy:multi_flower_2
Wuzzy:dirt_redo
Wuzzy:craft_compat
Wuzzy:gold_coin_upgrade
Wuzzy:gold_coin
Wuzzy:new_traders
Wuzzy:item_frame_flat
Wuzzy:silktouch_paint
Wuzzy:silktouch
Wuzzy:newtrees
Wuzzy:new_weather
Wuzzy:creative_per_player
Wuzzy:scrollbar_style
Wuzzy:village_nextgen_thread
Wuzzy:village_nextgen
Wuzzy:new_website
Wuzzy:tnt_faster
Wuzzy:fixbrush
Wuzzy:roots
Wuzzy:amber_slime
Wuzzy:fir
Wuzzy:path_fixes
Wuzzy:villager_pathfind_cost
Wuzzy:fence_gate
Wuzzy:slab_up
Wuzzy:biome_skies
Wuzzy:pencil_showlabel
Wuzzy:moonflower_seed
Wuzzy:unicode_signs_refactor_newsigns_sideways
Wuzzy:unicode_signs
Wuzzy:spyglass
Wuzzy:craftcolor
Wuzzy:villager_pathfind
Wuzzy:mobs_new2
Wuzzy:paint_book
Wuzzy:moon_phases
Wuzzy:newmusic
Wuzzy:weblate_test
Wuzzy:paint4dir
Wuzzy:whistle
Wuzzy:buoy
Wuzzy:pot
Wuzzy:4x4grass
Wuzzy:village_vmanip
Wuzzy:seagrass
First-time contributor
Copy link

A simple addition, this lets the VH1 mod know when a mob's hp is altered.
Bars appear automatically over the mob when damaged, and disappear shortly after healed to full, or when the mob is removed when dead.

A simple addition, this lets the VH1 mod know when a mob's hp is altered. Bars appear automatically over the mob when damaged, and disappear shortly after healed to full, or when the mob is removed when dead.
Owner
Copy link

While I appreciate your PR, I think this is the wrong approach because Repixture has to know about your mod and then support it for all eternity. No way.

Rather than hardcoding external mod-related code into Repixture, Repixture should instead offer some callback function to tell your mod when mob HP has changed. I am willing to accept a PR that adds such a callback. There's already a register_on_die function in rp_mobs.

I should maybe consider of adding mob HP bars natively anyway. Players already have a HP bar, but not mobs (oddly). See rp_headbars. I'm not 100% sure about that yet.

While I appreciate your PR, I think this is the wrong approach because Repixture has to know about your mod and then support it for all eternity. No way. Rather than hardcoding external mod-related code into Repixture, Repixture should instead offer some callback function to tell your mod when mob HP has changed. I am willing to accept a PR that adds such a callback. There's already a `register_on_die` function in `rp_mobs`. I should maybe consider of adding mob HP bars natively anyway. Players already have a HP bar, but not mobs (oddly). See `rp_headbars`. I'm not 100% sure about that yet.
Wuzzy closed this pull request 2024年04月06日 09:49:07 +02:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
No reviewers
Labels
Clear labels
Category: Discussion
For discussions about the game
Category: Entities
About entities or objects (including player)
Category: Gameplay
About gameplay mechanics in general
Category: Graphics
About graphics
Category: GUI and HUD
Anything related to the graphical user interface or heads-up display
Category: Items and Tools
About items or tools, but not nodes
Category: Mapgen
About the map generator
Category: Nodes
About nodes
Category: Sounds
About sounds
Category: Translation
About translations
Category: Website
Related to the Repixture website
Kind
Balancing
 About game balance
Kind
Bug
 When something doesn't work right
Kind
Documentation
 About documentation, both for devs and players
Kind
Feature
 Ideas, feature requests, enhancements, etc.
Kind
Maintenance
 Code quality, technical improvements, refactoring, etc.
Kind
Performance
 About making the game run fast
Priority
CRITICAL
 Highest priority level. For crashes, major data loss, etc.
Priority
High
 The priority is high
Priority
Low
 The priority is low
Priority
Medium
 The priority is medium
Reviewed
Decision needed
 When the issue still needs a decision on what to do
Reviewed
Duplicate
 When the issue existed already
Reviewed
Invalid
 When the issue was not valid
Reviewed
Rejected
 When something that was proposed was rejected
Status
Needs engine change
 When it can only be solved after a Luanti bugfix/improvement
Status
Needs testing
 If the task is believed to be done, but needs testing
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Wuzzy/Repixture!151
Reference in a new issue
Wuzzy/Repixture
No description provided.
Delete branch "Mantar/Repixture:VH1_support"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?