1
0
Fork
You've already forked DDD
0

Fix fetching latest episode no by using class post__title in soup #1

Merged
many-fac3d-g0d merged 1 commit from fix-recent-episode into main 2022年06月21日 22:43:49 +02:00
many-fac3d-g0d commented 2022年06月21日 17:11:48 +02:00 (Migrated from github.com)
Copy link

@Psyhackological Got this error while running the script

Traceback (most recent call last):
File "D:\softwares\Programs\DDD\DDD.py", line 1, in
import DDJ
File "D:\softwares\Programs\DDD\DDJ.py", line 24, in
recent_episode_nr = get_recent_episode_nr() # TODO ConnectionError exception
File "D:\softwares\Programs\DDD\DDJ.py", line 17, in get_recent_episode_nr
return int(recent_episode_str)
ValueError: invalid literal for int() with base 10: 'rc'

Some break in parsing the a_href and fetching the latest episode no. Fixed it by parsing bsoup using class name.
image

Nice tool btw :)

@Psyhackological Got this error while running the script Traceback (most recent call last): File "D:\softwares\Programs\DDD\DDD.py", line 1, in <module> import DDJ File "D:\softwares\Programs\DDD\DDJ.py", line 24, in <module> recent_episode_nr = get_recent_episode_nr() # TODO ConnectionError exception File "D:\softwares\Programs\DDD\DDJ.py", line 17, in get_recent_episode_nr return int(recent_episode_str) ValueError: invalid literal for int() with base 10: 'rc' Some break in parsing the a_href and fetching the latest episode no. Fixed it by parsing bsoup using class name. ![image](https://user-images.githubusercontent.com/54078651/174834427-0c380cac-e1f8-4549-a695-e5f2d4d882f6.png) Nice tool btw :)
Psyhackological commented 2022年06月21日 22:43:41 +02:00 (Migrated from github.com)
Copy link

Hi many faced God,
Thank you very much for interests and your pull request!

Ahh I see. Well I'm not gonna lie - this was my first project using BeautifulSoup and currently I know about passing this key-word argument. Good catch. I know there are still some bugs however I'm going to work on this project soon. Sorry for abandoning it!

Thanks for Nice tool btw :) however I don't know how useful it is once I discovered the official way of downloading all episodes. Maybe at least I can use this link list.

Hi many faced God, Thank you very much for interests and your pull request! Ahh I see. Well I'm not gonna lie - this was my first project using BeautifulSoup and currently I know about passing this key-word argument. Good catch. I know there are still some bugs however I'm going to work on this project soon. Sorry for abandoning it! Thanks for `Nice tool btw :)` however I don't know how useful it is once I discovered [the official way of downloading all episodes](https://darknetdiaries.com/downloadall/). Maybe at least I can use this [link list](https://darknetdiaries.com/darknet-diaries-all-episode-links.txt).
many-fac3d-g0d commented 2022年06月25日 08:28:43 +02:00 (Migrated from github.com)
Copy link

Hi many faced God, Thank you very much for interests and your pull request!

Ahh I see. Well I'm not gonna lie - this was my first project using BeautifulSoup and currently I know about passing this key-word argument. Good catch. I know there are still some bugs however I'm going to work on this project soon. Sorry for abandoning it!

Thanks for Nice tool btw :) however I don't know how useful it is once I discovered the official way of downloading all episodes. Maybe at least I can use this link list.

https://darknetdiaries.com/downloadall/- dis is new info for me thanks, appreciate it. Still the tool can b used for downloading specified range of episodes, although my use case was full bulk download.

> Hi many faced God, Thank you very much for interests and your pull request! > > Ahh I see. Well I'm not gonna lie - this was my first project using BeautifulSoup and currently I know about passing this key-word argument. Good catch. I know there are still some bugs however I'm going to work on this project soon. Sorry for abandoning it! > > Thanks for `Nice tool btw :)` however I don't know how useful it is once I discovered [the official way of downloading all episodes](https://darknetdiaries.com/downloadall/). Maybe at least I can use this [link list](https://darknetdiaries.com/darknet-diaries-all-episode-links.txt). https://darknetdiaries.com/downloadall/- dis is new info for me thanks, appreciate it. Still the tool can b used for downloading specified range of episodes, although my use case was full bulk download.
Sign in to join this conversation.
No reviewers
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Psyhackological/DDD!1
Reference in a new issue
Psyhackological/DDD
No description provided.
Delete branch "fix-recent-episode"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?