This issue tracker has been migrated to GitHub ,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2015年03月15日 15:10 by ethan.furman, last changed 2022年04月11日 14:58 by admin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| issue23673.stoneleaf.01.patch | ethan.furman, 2015年03月16日 17:59 | review | ||
| Messages (4) | |||
|---|---|---|---|
| msg238148 - (view) | Author: Ethan Furman (ethan.furman) * (Python committer) | Date: 2015年03月15日 15:10 | |
IntEnum is advertised as being a drop-in replacement for integer contants; however this fails in the case of unpickling on previous Python versions. This occurs because when a pickle is created the module, class, and value are stored -- but those don't exist prior to Python 3.4. One solution is to modify IntEnum to pickle just like a plain int would, but this has the serious disadvantage of losing the benefits of IntEnum on Python versions that support it. Another solution is to use Serhiy's idea of pickling by name; this would store the module and name to look up in that madule, and this works on all Python versions that have that constant: on Python 3.3 socket.AF_INET returns an integerer (2, I think), and on Python 3.4+ it returns the AF_INET AddressFamily member. |
|||
| msg238235 - (view) | Author: Ethan Furman (ethan.furman) * (Python committer) | Date: 2015年03月16日 17:59 | |
Patch adds Enum._convert which is a class method that handles:
- creating the new Enum
- adding the appropriate members
- adding the new Enum to the module's namespace (which is a passed parameter)
- replacing the __reduce_ex__ method to return just the member's name
The change to Enum is:
@classmethod
def _convert(cls, name, module, filter, source=None):
"""
Create a new Enum subclass that replaces a collection of global constants
"""
# convert all constants from source (or module) that pass filter() to
# a new Enum called name, and export the enum and its members back to
# module;
# also, replace the __reduce_ex__ method so unpickling works in
# previous Python versions
module_globals = vars(sys.modules[module])
if source:
source = vars(source)
else:
source = module_globals
members = {name: value for name, value in source.items()
if filter(name)}
cls = cls(name, members, module=module)
cls.__reduce_ex__ = _reduce_ex_by_name
module_globals.update(cls.__members__)
module_globals[name] = cls
return cls
In use it looks like:
IntEnum._convert(
'AddressFamily',
__name__,
lambda C: C.isupper() and C.startswith('AF_'))
or
_IntEnum._convert(
'_SSLMethod', __name__,
lambda name: name.startswith('PROTOCOL_'),
source=_ssl)
ssl.py, socket.py, signal.py, and http/__init__.py have been updated to use this method.
|
|||
| msg238483 - (view) | Author: Roundup Robot (python-dev) (Python triager) | Date: 2015年03月19日 00:28 | |
New changeset c93d46fd85ee by Ethan Furman in branch 'default': issue23673 https://hg.python.org/cpython/rev/c93d46fd85ee |
|||
| msg238486 - (view) | Author: Roundup Robot (python-dev) (Python triager) | Date: 2015年03月19日 01:24 | |
New changeset 5dd7b5fb65e7 by Ethan Furman in branch '3.4': issue23673 https://hg.python.org/cpython/rev/5dd7b5fb65e7 |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022年04月11日 14:58:13 | admin | set | github: 67861 |
| 2015年03月19日 01:29:05 | ethan.furman | set | status: open -> closed resolution: fixed stage: patch review -> resolved |
| 2015年03月19日 01:24:08 | python-dev | set | messages: + msg238486 |
| 2015年03月19日 00:35:04 | ethan.furman | link | issue20680 superseder |
| 2015年03月19日 00:28:30 | python-dev | set | nosy:
+ python-dev messages: + msg238483 |
| 2015年03月16日 17:59:28 | ethan.furman | set | files:
+ issue23673.stoneleaf.01.patch keywords: + patch messages: + msg238235 stage: test needed -> patch review |
| 2015年03月15日 15:10:45 | ethan.furman | create | |