homepage

Hello!
Given the fact that issue 17487 was accepted, I think that is a good idea for aifc.Aifc_read/Aifc_write.getparams to return a namedtuple as well, so that both modules will behave consistently with each other. 
I've attached a patch for this. 
Thanks in advance!

I made review comments: patch looks good, tests need a bit of work. Would you be interested in adding the What's New entry as well? (Doc/whatsnew/3.4).

Hello. I changed the patch according to your review comments. Here is the new version.

There is a regression. The result of getparams() was pickable, but now it is not.
I have added other comments on Rietveld.

I've modified the patch according to your comments, thanks! Now the result of getparams() is picklable again.

Can anyone review the latest patch, please? Thanks.

I've got it on my list, but I'm very busy for the next couple weeks. If someone else gets to it first that's good too :)

The patch looks good to me. Can you add a pickling test?

Here's the new patch. Also, I noticed a test failing when running ./python -m test, pyclbr, complaining about _Aifc_params not present in some dict, but I don't really know how to fix it..

pyclbr is parsing the source code, and since _Aifc_params is not a class, it does not get detected. So we just need to add it to the ignore list in the pyclbr test.
I'm also getting this when I run the test with your patch applied:
/home/rdmurray/python/p34/Lib/unittest/case.py:496: ResourceWarning: unclosed file <_io.BufferedReader name='@test_9764_tmp'>
 testMethod()
Looks like you are missing a close or two.
Oh, and it occurs to me that _Aifc_params doesn't follow pep8. aifc should either be all lower case or, if you are viewing it as a class, it should be _AIFCParams.

Here's the new modifications.

New changeset 560c6e9d1beb by R David Murray in branch 'default':
#17818: aifc.getparams now returns a namedtuple.
http://hg.python.org/cpython/rev/560c6e9d1beb 

Thanks, Claudiu.