homepage

wave.Wave_read/Wave_write.getparams returns a tuple with various info about the wav file, when it could return a namedtuple, that can be manipulated in a richer way. I attached a patch. It doesn't have any tests, mainly because .getparams isn't tested at all in the original test_wave.py.

This seems like a reasonable idea to me, thanks for the patch.
Adding tests for getparams would be a good thing ;)

Updated the patch with test for .getparams.

Looks good.
Claudio, could you please submit a contributor agreement? (http:://www.python.org/psf/contrib).

Should the documentation of the wave module be updated to match this change? See issue 16808 for example.
The current wave.Wave_read.getparams documentation says:
"Returns a tuple (nchannels, sampwidth, framerate, nframes, comptype, compname), equivalent to output of the get*() methods."
http://docs.python.org/3.4/library/wave.html#wave.Wave_read.getparams 

It should. Here's the patch I am prepared to commit once Claudio's contributor for confirmation occurs.

Hello, I signed the electronic contributor agreement (I received a mail with the final copy afterwards). Is there something else that I should do or that is the entire process?

I backed it out until it can be done without breaking OSX. d174cb3f5b9e 

Wrong issue, sorry.

Claudiu: that's the entire process. Now we just wait a day or two until the confirmation arrives from the PSF that they have accepted it (you'll get an '*' next to your name here in the tracker when that happens).

Hello. I received the confirmation for my CLA, could you commit the patch? Thank you!

New changeset 340a12c18b7f by R David Murray in branch 'default':
#17487: wave.getparams now returns a namedtuple.
http://hg.python.org/cpython/rev/340a12c18b7f 

Thanks, Claudiu.

There is a regression with the latest patch, `getparams` output is no longer picklable. The attached patch fixes this issue. Also, I renamed the internal namedtuple to something more meaningful.

New changeset a14ec46de0a4 by Serhiy Storchaka in branch 'default':
Issue #17487: The result of the wave getparams method now is pickleable again.
http://hg.python.org/cpython/rev/a14ec46de0a4 

Thank you Claudiu. I have changed _Wave_params to _wave_params for consistency with issue17818 and issue18901.