UIFe: Panel - Indicators should be orderable regardless of their parent IndicatorObject
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Unity |
Fix Released
|
High
|
Marco Trevisan (Treviño) | ||
| unity-2d |
Fix Released
|
Undecided
|
Marco Trevisan (Treviño) | ||
| unity (Ubuntu) |
Fix Released
|
Undecided
|
Marco Trevisan (Treviño) | ||
| unity-2d (Ubuntu) |
Fix Released
|
Undecided
|
Marco Trevisan (Treviño) | ||
Bug Description
According to this design wiki [1] the indicators should be ordered regardless of their parent indicator position, and should be possible to mix app-indicators and other system indicators.
Basically it should be possible to show the nm-applet indicator inside the set of the system indicators, also if it's an app-indicator. Also, we could provide a way for users to define their custom indicators order.
[1] https:/
UIFe: This changes the ordering of the indicators to match the design, however it does *not* change any strings, so translations are not effected.
Related branches
- Florian Boucault (community): Approve
- Neil J. Patel (community): Approve
-
Diff: 2704 lines (+927/-481) 24 files modifiedapiUnityCore/DBusIndicators.cpp (+49/-32)
UnityCore/Indicator.cpp (+55/-37)
UnityCore/Indicator.h (+7/-3)
UnityCore/IndicatorEntry.cpp (+55/-2)
UnityCore/IndicatorEntry.h (+14/-2)
UnityCore/Indicators.cpp (+58/-10)
UnityCore/Indicators.h (+7/-1)
plugins/unityshell/src/PanelIndicatorEntryView.cpp (+42/-33)
plugins/unityshell/src/PanelIndicatorEntryView.h (+7/-6)
plugins/unityshell/src/PanelIndicatorsView.cpp (+164/-87)
plugins/unityshell/src/PanelIndicatorsView.h (+33/-27)
plugins/unityshell/src/PanelMenuView.cpp (+14/-24)
plugins/unityshell/src/PanelMenuView.h (+6/-8)
plugins/unityshell/src/PanelTray.cpp (+8/-8)
plugins/unityshell/src/PanelTray.h (+3/-6)
plugins/unityshell/src/PanelView.cpp (+60/-53)
plugins/unityshell/src/PanelView.h (+6/-4)
services/panel-main.c (+23/-6)
services/panel-root-accessible.c (+1/-1)
services/panel-service.c (+278/-107)
services/panel-service.h (+6/-1)
tests/CMakeLists.txt (+4/-4)
tests/test_indicator_entry.cpp (+20/-16)
tests/unit/TestPanelService.cpp (+7/-3)
- Florian Boucault: Pending requested
-
Diff: 201 lines (+84/-11) 6 files modifiedapilibunity-2d-private/src/indicatorswidget.cpp (+26/-3)
libunity-2d-private/src/indicatorswidget.h (+6/-1)
panel/applets/appname/menubarwidget.cpp (+26/-2)
panel/applets/appname/menubarwidget.h (+6/-0)
panel/applets/indicator/indicatorapplet.cpp (+19/-5)
panel/applets/indicator/indicatorapplet.h (+1/-0)
+ UIFe: Panel - Indicators should be orderable regardless of their parent
IndicatorObject
TBH, I'm not convinced that this feature is important enough to land now (and we have worse itches to scratch than spending development time on this right now).
Documentation team, how many screenshots (roughly) do we have which shows indicators? Do we have translated screenshots? We'd need to replace them all if this would land. Do you have an opinion about this request?
More specifically, this bug is actually about just moving the network menu two places to the right. As pitti says, this definitely isn't a high priority bug.
Are you moving the bluetooth indicator as well?
Documentation team impact is that we need to reorder https:/
a discussion happened on #ubuntu-desktop between jbicha, pitti and njpatel to address this concern.
The bluetooth menu has moved also to remain directly left of the network menu and right of the power menu.
@pitti @jbicha I sent this merge request about 15 days before the UI freeze, but unfortunately it has not been possible to merge.
I know that just moving two indicators is not a priority thing, but it is a main rework of all the indicators infrastructure that should also give better performances and less memory usage.
Also, from a development point of view but this will also allow in future to easily make system indicators and put them in the right position without using libindicate directly, but with a simple app-indicator.
This bug was fixed in the package unity - 4.14.2-0ubuntu1
---------------
unity (4.14.2-0ubuntu1) oneiric; urgency=low
* New upstream release.
- unity crashed with AttributeError in reset_unity_
object has no attribute 'get_string' (LP: #809378)
- Trying to minimize Unity Dash to make it fit on a 1024x768 screen makes
Unity freeze and then, after I log out by killing X, never start again
(LP: #839200)
- unity-panel-service crashed with SIGSEGV in main_arena() (LP: #817477)
- UIFe: Panel - Indicators should be orderable regardless of their parent
Indicator
- 'Show Desktop' fails to hand focus to desktop (LP: #836315)
- Dash - Functionality of top left close, minimise and maximise/restore
window decorations is confused (LP: #838875)
- unity-panel-service Leaks Memory (LP: #779185)
- Missing lens shortcuts (Super-A, Super-F) (LP: #834078)
- Unity window switcher takes over <alt> key (LP: #835699)
- update assets for window buttons (topleft) with dash opened
(LP: #836655)
- Where the average background colour is either very light or dark, adjust
this value to darken/lighten in order to preserve readability
(LP: #837993)
- Applications don't have priority over other results (LP: #839518)
- task tray icons are misaligned and badly sized (LP: #839354)
- UIFe: Dash - Shape and positioning of most of the elements in the Dash
need adjustment (LP: #841945)
- Cannot drag applications from dash to desktop (LP: #756614)
- systray icons still visible on each desktop in expo mode (LP: #759129)
- transparency on unity panel broken (LP: #827012)
- Window buttons and application menu don't autohide if left edge is
touched (LP: #835637)
- 'Filter results' should be right indented as in the mockups(and unity-
2d) (LP: #838118)
- window title should not appear until cursor leaves the menubar
(LP: #838759)
- Window title is not redrawn on leaving global-menu from buttons
(LP: #839488)
- In the dash, main text field can not be edited, except at the end
(LP: #840862)
- Quicklist can't be correctly hidden (LP: #843425)
- After double clicking on the panel to restore a window, the menus won't
be hidden on mouse-out (LP: #838021)
- After restoring a window the application title doesn't fade-out and it
goes below the menus (LP: #838479)
* debian/control:
- build-dep on latest libunity-dev for ABI/API break, nux
* debian/rules:
- bump shlibs, remove tweak for garantuing the version as the ABI
is considered stable until finale now.
-- Didier Roche <email address hidden> 2011年9月08日 20:07:50 +0200