-
-
Notifications
You must be signed in to change notification settings - Fork 158
Update test suite to use PCOV to avoid segfault with Xdebug 3.4.2 #323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@WyriHaximus
WyriHaximus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
clue
commented
Jul 21, 2025
For the reference: Xdebug 3.4.5 has been released last week (https://github.com/xdebug/xdebug/releases/tag/3.4.5) with the above bug fixed, so the segfault should no longer be an issue.
We've briefly discussed reverting this internally and figured this would introduce unneeded noise at the moment, so we'll likely stick with a mix of Xdebug and PCOV for any projects migrated in the meantime. There is a chance either may break in the future, so I think it's good we have both at our disposal in case this happens.
Builds on top of reactphp#269, reactphp#270 and reactphp/socket#323 by backporting reactphp#279 to v1.
Builds on top of reactphp#269, reactphp#270 and reactphp/socket#323 by backporting reactphp#279 to v1.
Builds on top of reactphp#269, reactphp#270 and reactphp/socket#323 by backporting reactphp#279 to v1.
Builds on top of reactphp#269, reactphp#270 and reactphp/socket#323 by backporting reactphp#279 to v1.
Builds on top of reactphp#269, reactphp#270 and reactphp/socket#323 by backporting reactphp#279 to v1.
This changeset updates the test suite to use PCOV instead of Xdebug on PHP 8+ to avoid a segfault with Xdebug 3.4.2 on PHP 8.1+ (https://bugs.xdebug.org/view.php?id=2332).
Unfortunately, it doesn't look like the upstream bug in Xdebug is an easy fix nor like it is going to be fixed any time soon, so for the time being I'd propose switching to PCOV to unblock our development. PCOV is pretty much a drop-in replacement on newer PHP versions (but noticeably faster), and test coverage should not be affected at all. Once merged, we should apply similar changes to our other components and other supported branches.
Builds on top of clue/framework-x#278 and #321
Supersedes / closes #322