-
-
Notifications
You must be signed in to change notification settings - Fork 131
Run tests on PHP 8.4 and update test environment + PCOV to avoid segfault with Xdebug 3.4.2 #279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
d9b78c6 to
0b2a3c3
Compare
PaulRotmann
commented
Jul 22, 2025
I refactored the CI workflow using a new approach with a ternary expression to conditionally include the appropriate ev extension version based on PHP. This greatly simplified the setup and made many of the previous redundant changes unnecessary.
The tests now run cleanly in GitHub Actions with ev installed properly on all targeted PHP versions. Thanks for the feedback, happy to adjust further if needed!
@clue
clue
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@PaulRotmann Thanks for the update, changes look much cleaner now, all LGTM 👍
Builds on top of reactphp#269, reactphp#270 and reactphp/socket#323 by backporting reactphp#279 to v1.
Builds on top of reactphp#269, reactphp#270 and reactphp/socket#323 by backporting reactphp#279 to v1.
Builds on top of reactphp#269, reactphp#270 and reactphp/socket#323 by backporting reactphp#279 to v1.
Builds on top of reactphp#269, reactphp#270 and reactphp/socket#323 by backporting reactphp#279 to v1.
Builds on top of reactphp#269, reactphp#270 and reactphp/socket#323 by backporting reactphp#279 to v1.
Builds on top of #269, #270 and reactphp/socket#323.
Also had to remove ext-ev from default extensions, install it explicitly based on PHP version.