Skip to content

Fix matchSubdomain function to correctly handle exact domain matches #2802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open

suwakei wants to merge 2 commits into labstack:master

from suwakei:fix/util.go

+11 −1

Open

Fix matchSubdomain function to correctly handle exact domain matches #2802

Changes from all commits

Commits

Show all changes

Select commit Hold shift + click to select a range

Bug fixes in matchSubdomain function

suwakei Jul 14, 2025

suwakei Jul 16, 2025

File filter

Filter by extension

Conversations

Jump to

Jump to file

Failed to load files.

Loading

Diff view

Diff view

2 changes: 1 addition & 1 deletion middleware/util.go

Show comments View file Open in desktop

Original file line number	Diff line number	Diff line change
Expand Up		@@ -57,7 +57,7 @@ func matchSubdomain(domain, pattern string) bool {
		return false
		}
		}
	return false
	return len(domComp) == len(patComp)
		}

		// https://tip.golang.org/doc/go1.19#:~:text=Read%20no%20longer%20buffers%20random%20data%20obtained%20from%20the%20operating%20system%20between%20calls
Expand Down

10 changes: 10 additions & 0 deletions middleware/util_test.go

Show comments View file Open in desktop

Original file line number	Diff line number	Diff line change
Expand Up		@@ -47,6 +47,16 @@ func Test_matchSubdomain(t *testing.T) {
		domain, pattern string
		expected bool
		}{
	{
	domain: "http://example.com",
	pattern: "http://example.com",
	expected: true,
	},
	{
	domain: "http://example.com",
	pattern: "https://example.com",
	expected: false,
	},
		{
		domain: "http://aaa.example.com",
		pattern: "http://*.example.com",
Expand Down