-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Fix matchSubdomain function to correctly handle exact domain matches #2802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
+11
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
suwakei
commented
Jul 16, 2025
Hi! Just following up to see if there's anything I can improve in this PR 🙇
FrancoTampieri
commented
Jul 16, 2025
My two cents:
I think the only think is missed the specific test for that case in util_test.go
Author
suwakei
commented
Jul 16, 2025
I added specific unit test
Author
suwakei
commented
Jul 29, 2025
Hi maintainers 👋
Just following up on this PR — happy to make any changes if needed. Please let me know if there's anything blocking review. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Problem
The
matchSubdomainfunction incorrectly returnsfalsefor exact domain matches without wildcards—for example,http://example.comvs.http://example.com.Cause
Even if all parts match during iteration, the function still returns false at the end.
Fix
After the loop, if all parts match and the number of parts is equal between the pattern and the domain, it should return
true—i.e., treat it as an exact match.This PR adds that check.