Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix matchSubdomain function to correctly handle exact domain matches #2802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
suwakei wants to merge 2 commits into labstack:master
base: master
Choose a base branch
Loading
from suwakei:fix/util.go

Conversation

@suwakei
Copy link

@suwakei suwakei commented Jul 14, 2025
edited
Loading

Problem

The matchSubdomain function incorrectly returns false for exact domain matches without wildcards—for example, http://example.com vs. http://example.com.

Cause

Even if all parts match during iteration, the function still returns false at the end.

Fix

After the loop, if all parts match and the number of parts is equal between the pattern and the domain, it should return true—i.e., treat it as an exact match.

This PR adds that check.

Copy link
Author

suwakei commented Jul 16, 2025

Hi! Just following up to see if there's anything I can improve in this PR 🙇

Copy link

My two cents:
I think the only think is missed the specific test for that case in util_test.go

suwakei reacted with thumbs up emoji

Copy link
Author

suwakei commented Jul 16, 2025

I added specific unit test

FrancoTampieri reacted with thumbs up emoji

Copy link
Author

suwakei commented Jul 29, 2025

Hi maintainers 👋
Just following up on this PR — happy to make any changes if needed. Please let me know if there's anything blocking review. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /