-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Rust: Exclude self parameter accesses from rust/access-after-lifetime-ended #21155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
+56
−1
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
06c34fd
Rust: Add test case for rust/access-after-lifetime-ended involving a ...
geoffw0 3792adf
Rust: For now lets just exclude self parameters from the query sources.
geoffw0 bed8106
Rust: Rename the test case now that I've figured out exactly what the...
geoffw0 d88e71a
Rust: Change note.
geoffw0 91ab686
Rust: Fix the change note file name.
geoffw0 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 4 additions & 0 deletions
rust/ql/src/change-notes/2026-01-13-access-after-lifetime-ended.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| --- | ||
| category: minorAnalysis | ||
| --- | ||
| * Fixed false positives from the `rust/access-after-lifetime-ended` query, involving pointers to fields of `self`. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -857,3 +857,50 @@ pub fn test_generic() { | |
| let result = generic_caller::<MyProcessor>(); | ||
| println!(" result = {result}"); | ||
| } | ||
|
|
||
| // --- self --- | ||
|
|
||
| struct MyObjectWithGetters { | ||
| value: i64 | ||
| } | ||
|
|
||
| impl MyObjectWithGetters { | ||
| pub fn new(_value: i64) -> Self { | ||
| Self { | ||
| value: _value | ||
| } | ||
| } | ||
|
|
||
| pub unsafe fn get_ptr1(&self) -> *const i64 { | ||
| &raw const self.value // $ MISSING: Source[rust/access-after-lifetime-ended]=self_value | ||
| // (the returned pointer is valid as long as the containing object is) | ||
| } | ||
|
|
||
| pub unsafe fn get_ptr2(self) -> *const i64 { | ||
| &raw const self.value // $ MISSING: Source[rust/access-after-lifetime-ended]=self_value | ||
| // (the returned pointer is valid as long as the containing object is) | ||
| } | ||
| } | ||
|
|
||
| pub fn test_get_self() { | ||
| let ptr1: *const i64; | ||
| let ptr2: *const i64; | ||
|
|
||
| unsafe { | ||
| let obj = MyObjectWithGetters::new(1111); | ||
| ptr1 = obj.get_ptr1(); | ||
| ptr2 = obj.get_ptr2(); | ||
|
|
||
| let v1 = *ptr1; // GOOD | ||
| let v2 = *ptr2; // GOOD | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This one is in fact bad. I tried inserting
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. That's interesting ... then I think the first step to fixing this PR is going to be correcting and expanding the test cases. |
||
| println!(" v1 = {}", v1); | ||
| println!(" v2 = {}", v2); | ||
| } | ||
|
|
||
| use_the_stack(); | ||
|
|
||
| let v3 = unsafe { *ptr1 }; // $ MISSING: Alert[rust/access-after-lifetime-ended]=self_value | ||
| let v4 = unsafe { *ptr2 }; // $ MISSING: Alert[rust/access-after-lifetime-ended]=self_value | ||
| println!(" v3 = {} (!)", v3); | ||
| println!(" v4 = {} (!)", v4); // corrupt in practice | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -215,4 +215,7 @@ fn main() { | |
|
|
||
| println!("test_generic:"); | ||
| test_generic(); | ||
|
|
||
| println!("test_get_self:"); | ||
| test_get_self(); | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.