Pull request overview

This PR refines the rust/access-after-lifetime-ended query by excluding self parameter accesses from being treated as sources. The query doesn't attempt to track object lifetimes, so including self parameters was unintended and produced suboptimal results.

Changes:

• Modified the query logic to filter out self parameters when identifying potential lifetime-ending variable accesses
• Added a comprehensive test case demonstrating methods with both &self and self parameters that return pointers to internal fields
• Updated the test runner to execute the new test case

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

I don't understand why we want to treat self as special here? For the purpose of this query I'd think self is just a parameter as any other.

Let's say I change the self parameter to foo parameter like in the diff below. I haven't really changed the behavior of the program in any way, so I'd expect the query results to not change either?

For &raw foo.bar we already have implemented the fact that this tracks the lifetime of foo. And per my other comments it seems that the query results prior to the self might in fact be just fine?

@@ -871,13 +871,13 @@ impl MyObjectWithGetters {
 }
 }
 
- pub unsafe fn get_ptr1(&self) -> *const i64 {
- &raw const self.value // $ MISSING: Source[rust/access-after-lifetime-ended]=self_value
+ pub unsafe fn get_ptr1(foo: &Self) -> *const i64 {
+ &raw const foo.value // $ MISSING: Source[rust/access-after-lifetime-ended]=self_value
 // (the returned pointer is valid as long as the containing object is)
 }
 
- pub unsafe fn get_ptr2(self) -> *const i64 {
- &raw const self.value // $ MISSING: Source[rust/access-after-lifetime-ended]=self_value
+ pub unsafe fn get_ptr2(foo: Self) -> *const i64 {
+ &raw const foo.value // $ MISSING: Source[rust/access-after-lifetime-ended]=foo_value
 // (the returned pointer is valid as long as the containing object is)
 }
 }
@@ -888,8 +888,8 @@ pub fn test_get_self() {
 
 unsafe {
 let obj = MyObjectWithGetters::new(1111);
- ptr1 = obj.get_ptr1();
- ptr2 = obj.get_ptr2();
+ ptr1 = MyObjectWithGetters::get_ptr1(&obj);
+ ptr2 = MyObjectWithGetters::get_ptr2(obj);
 
 let v1 = *ptr1; // GOOD
 let v2 = *ptr2; // GOOD