feat: add --allow-no-commit option #723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

Lee-W merged 4 commits into commitizen-tools:master from 12rambau:empty

Feb 7, 2025

Merged

feat: add --allow-no-commit option #723

Lee-W merged 4 commits into commitizen-tools:master from 12rambau:empty

Feb 7, 2025

Conversation

@12rambau

Copy link

Contributor

@12rambau 12rambau commented Apr 24, 2023

superceed #696

Description

First draft of a new feature. The idea is to grant the user the capability to run cz bump without prior commits. The reasons are described in the associated issue.

here we add an --empty parameter to the bump method
when this parameter is set and if no increment is find, a automatic "PATCH" is released.

I'll wait for your feedback before working on tests and documentation.

Checklist

Add test cases to all the changes you introduce
Run ./scripts/format and ./scripts/test locally to ensure this change passes linter check and test
Test the changes on the local machine manually
Update the documentation for the changes

Additional context

Fix #662

@codecov

Copy link

codecov bot commented Apr 24, 2023 •

edited

Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.59%. Comparing base (120d514) to head (10740c9).
Report is 551 commits behind head on master.

Additional details and impacted files

@@ Coverage Diff @@
## master #723 +/- ##
==========================================
+ Coverage 97.33% 97.59% +0.25% 
==========================================
 Files 42 55 +13 
 Lines 2104 2617 +513 
==========================================
+ Hits 2048 2554 +506 
- Misses 56 63 +7

Flag	Coverage Δ
unittests	`97.59% <100.00%> (+0.25%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@woile

Copy link

Member

woile commented Apr 24, 2023

LGTM 💪🏻 , needs tests though

@12rambau

Copy link

Contributor Author

12rambau commented Apr 24, 2023

🍾 Nice to see that you approve the idea.

needs tests though

absolutely, I'll work on them this week (I hope)

@woile woile requested a review from Lee-W

April 28, 2023 07:42

Lee-W

Lee-W reviewed

May 6, 2023

View reviewed changes

Copy link

Member

@Lee-W Lee-W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I recently happen to work on a project need such feature lol 🎉

@Lee-W Lee-W added needs: test-case needs: documentation in progress labels

May 6, 2023

@Lee-W Lee-W added pr-status: wait-for-modification and removed in progress labels

Jun 23, 2023

@noirbizarre noirbizarre mentioned this pull request

Mar 5, 2024

Feature/allow empty commit #592

Closed

4 tasks

@Lee-W Lee-W self-requested a review

April 21, 2024 05:57

@Lee-W Lee-W force-pushed the empty branch from 5772b36 to 0999ef6 Compare

April 21, 2024 09:23

@12rambau 12rambau requested review from noirbizarre and woile as code owners

April 21, 2024 09:23

@github-actions github-actions bot added the pr-status: wait-for-review label

Apr 21, 2024

@Lee-W

Copy link

Member

@woile @noirbizarre, I picked this up and refactored it a bit. I changed the argument to --allow-no-commit. One weird thing that might happen is that one commit might have multiple versions. I'm not sure whether it would cause any issue

@12rambau

Copy link

Contributor Author

12rambau commented Apr 21, 2024

thanks @Lee-W

@noirbizarre noirbizarre mentioned this pull request

Apr 24, 2024

commitizen v4 #1073

Closed

3 tasks

@Lee-W Lee-W removed needs: test-case needs: documentation pr-status: wait-for-modification labels

Apr 29, 2024

@Lee-W Lee-W assigned noirbizarre and woile

May 20, 2024

@Lee-W Lee-W force-pushed the empty branch from 0999ef6 to c71773a Compare

May 20, 2024 17:58

12rambau and others added 2 commits

January 30, 2025 19:30

@12rambau @Lee-W


 feat: draft of the --empty parameter

78264a7

@Lee-W


 refactor(bump): rename --empty as --allow-no-commit

7d63120

@Lee-W Lee-W force-pushed the empty branch from c71773a to 94768af Compare

January 30, 2025 11:37

@Lee-W Lee-W changed the title ~~(削除) feat: draft of the --empty parameter (削除ここまで)~~ (追記) feat: add --allow-no-commit option (追記ここまで)

Jan 30, 2025

@Lee-W

Copy link

Member

Lee-W commented Jan 30, 2025

Hey @woile @noirbizarre , I just rebased it from the latest master branch. Would be nice if you could take a look. Thanks!

Lee-W added 2 commits

January 30, 2025 19:44

@Lee-W


 test(bump): add test cases for "--allow-no-commit" argument for bump ...

ba5a71a

...command

@Lee-W


 docs(bump): add description for bump "--allow-no-commit" argument

10740c9

@woile

Copy link

Member

woile commented Jan 30, 2025

Should this be exposed as a config parameter as well? besides that it looks good

@Lee-W

Copy link

Member

Lee-W commented Jan 30, 2025

Should this be exposed as a config parameter as well? besides that it looks good

Yep, could be. let me update it as well. Just notice the CI also failed 🤦‍♂️

@Lee-W Lee-W force-pushed the empty branch from 94768af to 10740c9 Compare

January 30, 2025 13:17

@Lee-W

Copy link

Member

Lee-W commented Jan 30, 2025

Should this be exposed as a config parameter as well? besides that it looks good

@woile After a second thought, I think we probably shouldn't add it. I feel this is somewhat like an exception, and if we're to do it, we probably need to introduce a better config/arugment handling to avoid #996

@woile

Copy link

Member

woile commented Jan 30, 2025

And there's still an issue with vsc with no commits

@Lee-W

Copy link

Member

Lee-W commented Jan 31, 2025

And there's still an issue with vsc with no commits

I'm afraid I don't quite get this one 🤔

@noirbizarre

Copy link

Member

noirbizarre commented Jan 31, 2025

I'll take a look tomorrow 👍🏽

noirbizarre

noirbizarre approved these changes

Feb 7, 2025

View reviewed changes

Copy link

Member

@noirbizarre noirbizarre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! (before it reaches 2 years old, sorry for that)
This feature is needed. I think we can iterate on smaller pull request to add later settings or any other adjustments

@Lee-W Lee-W merged commit 2c97d02 into commitizen-tools:master

Feb 7, 2025

18 checks passed

@bearomorphism bearomorphism mentioned this pull request

Nov 19, 2025

fix(bump): extract option validation and new version resolution #1646

Merged

Labels

pr-status: wait-for-review

4 participants

@12rambau @woile @Lee-W @noirbizarre

Uh oh!

feat: add --allow-no-commit option #723

feat: add --allow-no-commit option #723

Uh oh!

Conversation

@12rambau 12rambau commented Apr 24, 2023

Description

Checklist

Additional context

Uh oh!

codecov bot commented Apr 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

woile commented Apr 24, 2023

Uh oh!

12rambau commented Apr 24, 2023

Uh oh!

@Lee-W Lee-W left a comment

Choose a reason for hiding this comment

Uh oh!

Lee-W commented Apr 21, 2024

Uh oh!

12rambau commented Apr 21, 2024

Uh oh!

Lee-W commented Jan 30, 2025

Uh oh!

woile commented Jan 30, 2025

Uh oh!

Lee-W commented Jan 30, 2025

Uh oh!

Lee-W commented Jan 30, 2025

Uh oh!

woile commented Jan 30, 2025

Uh oh!

Lee-W commented Jan 31, 2025

Uh oh!

noirbizarre commented Jan 31, 2025

Uh oh!

@noirbizarre noirbizarre left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov bot commented Apr 24, 2023 •

edited

Loading