Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

fix(bump): extract option validation and new version resolution #1646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Lee-W merged 1 commit into commitizen-tools:v4-10-1 from bearomorphism:bump-refactor
Nov 19, 2025

Conversation

@bearomorphism
Copy link
Collaborator

@bearomorphism bearomorphism commented Nov 11, 2025 •
edited
Loading

Changes

Relate #1643

  • Refactors
  • Collect all NotAllowed error messages and raise it at the end of option validation process

Copy link

codecov bot commented Nov 11, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (v4-10-1@280bea0). Learn more about missing BASE report.

Additional details and impacted files 
@@ Coverage Diff @@
## v4-10-1 #1646 +/- ##
==========================================
 Coverage ? 98.60% 
==========================================
 Files ? 60 
 Lines ? 2651 
 Branches ? 0 
==========================================
 Hits ? 2614 
 Misses ? 37 
 Partials ? 0
Flag Coverage Δ
unittests 98.60% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bearomorphism bearomorphism changed the title (削除) refactor(bump): extract option validation and new version resolution ... (削除ここまで) (追記) fix(bump): extract option validation and new version resolution ... (追記ここまで) Nov 11, 2025
@Lee-W Lee-W added this to the 4.10.1 milestone Nov 16, 2025
@Lee-W Lee-W changed the title (削除) fix(bump): extract option validation and new version resolution ... (削除ここまで) (追記) fix(bump): extract option validation and new version resolution (追記ここまで) Nov 16, 2025
Copy link
Member

@Lee-W Lee-W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly good. one minor question

@Lee-W Lee-W added pr-status: ready-to-merge almost ready to merge. just keep it for a few days for others to check and removed pr-status: wait-for-review labels Nov 19, 2025
@Lee-W Lee-W merged commit f52f532 into commitizen-tools:v4-10-1 Nov 19, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lee-W Lee-W Lee-W approved these changes

@woile woile Awaiting requested review from woile

@noirbizarre noirbizarre Awaiting requested review from noirbizarre

Assignees

No one assigned

Labels

pr-status: ready-to-merge almost ready to merge. just keep it for a few days for others to check pr-status: wait-for-review type: bug type: refactor

Projects

None yet

Milestone

4.10.1

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /