This repository was archived by the owner on Dec 15, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 408
[WIP] don't call method of destroyed webContents #2722
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@ ## master #2722 +/- ## ========================================== + Coverage 93.46% 93.47% +0.01% ========================================== Files 237 237 Lines 13213 13213 Branches 1900 1900 ========================================== + Hits 12349 12351 +2 + Misses 864 862 -2
Continue to review full report at Codecov.
|
Author
icecream17
commented
Oct 21, 2021
Okay, everything still seems to be the same....
Closed
@icecream17
icecream17
changed the title
(削除) don't call method of destroyed webContents (削除ここまで)
(追記) [WIP] don't call method of destroyed webContents (追記ここまで)
Dec 10, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Please be sure to read the contributor's guide to the GitHub package before submitting any pull requests.
Requirements
Description of the Change
The ubuntu tests have been failing, even for perfectly valid prs
One of the complained errors says "Attempting to call a function in a renderer window that has been closed or released."
EDIT: This appears in all the tests, so this error (or warning?) doesn't actually fail the tests
So I think this attempt removes the function call - and hopefully fixes the tests
Screenshot or Gif
image
Applicable Issues