This repository was archived by the owner on Dec 15, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 408
Use addEventListener
#2723
Closed
Closed
Use addEventListener
#2723
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have no idea why this error exists, but at least this is a change since I use `removeEventListener` too.
Codecov Report
@@ Coverage Diff @@ ## master #2723 +/- ## ========================================== - Coverage 93.46% 92.93% -0.53% ========================================== Files 237 237 Lines 13213 13213 Branches 1900 1900 ========================================== - Hits 12349 12279 -70 - Misses 864 934 +70
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt 2 (See attempt 1: #2722)
I have no idea why this error exists, but at least this is a change since I use
removeEventListenertoo.Please be sure to read the contributor's guide to the GitHub package before submitting any pull requests.
Requirements
Description of the Change
Screenshot or Gif
Applicable Issues
(theoretical)
fixes #769
fixes #954
resolves #2722