-
Notifications
You must be signed in to change notification settings - Fork 865
New cb third party lib #3411
New cb third party lib #3411
Conversation
googlebot
commented
Mar 22, 2017
So there's good news and bad news.
👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.
😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.
Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.
1 similar comment
googlebot
commented
Mar 22, 2017
So there's good news and bad news.
👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.
😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.
Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.
s s s s s c s c s s s s s s s s s s s s s s s s s s s s s s s s s
3925a03 to
f801cfd
Compare
@sumitarora
sumitarora
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@filipesilva I'm trying to build this and having some trouble. The npm install is failing because I am missing the dependency on angular-quickstart-lib. However, I am not sure how to build that file and the commands in the README are not working.
EDIT: I dug around a googled a bit and it looks like I might need to use ngc to compile what's in the src/lib folder? In any case, I'm getting the error "Error encountered resolving symbol values statically. Calling function 'ɵmakeDecorator', function calls are not supported." when I try that.
filipesilva
commented
Apr 12, 2017
@sirhcybe the starter mentioned in this document can be found at https://github.com/filipesilva/angular-quickstart-lib. The needed commands are present in that repository's package.json.
sirhcybe
commented
Apr 12, 2017
@filipesilva Ah yes, that works much better. Thank you.
Followup from #2758
Uses https://github.com/filipesilva/angular-quickstart-lib while that code is not transferred over to a Angular repo.