Search code, repositories, users, issues, pull requests...

Copy link

Contributor

@filipesilva filipesilva commented May 2, 2017 •

edited

Loading

Please check if the PR fulfills these requirements

The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Other... Please describe: AIO third party lib guide

What is the current behavior? (You can also link to an open issue here)
N/A

What is the new behavior?
A guide for third party library development is added. This PR is a port from angular/angular.io#3411.

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[x] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:
For now the quickstart lib seed is hosted at https://github.com/filipesilva/angular-quickstart-lib. It should be hosted under the angular org upon release.

/cc @wardbell @alxhub

@googlebot googlebot added the cla: yes label

May 2, 2017

@mary-poppins

Copy link

mary-poppins commented May 2, 2017

The angular.io preview for 1c9e4ce4cd170640def0191d93a57c88a22bf7aa is available here.

gkalpak

gkalpak reviewed

May 2, 2017

AOT error when referencing components from another project angular/angular-cli#6059

Copy link

Member

@gkalpak gkalpak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That will be really helpful for library authors 👍

aio/content/guide/third-party-lib.md Outdated

Copy link

Member

@gkalpak gkalpak May 2, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent capitalization AOT (here) vs AOT (above).

Copy link

Contributor Author

@filipesilva filipesilva May 10, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

aio/content/guide/third-party-lib.md Outdated

Copy link

Member

@gkalpak gkalpak May 2, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've noticed several variations throughout the text for terms like AOT anf JIT (e.g. "AoT" vs "AOT", "Ahead of Time" vs "Ahead-of-time" etc). I think we should be consistent.

Copy link

Contributor Author

@filipesilva filipesilva May 10, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

aio/content/guide/third-party-lib.md Outdated

Copy link

Member

@gkalpak gkalpak May 2, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bundle --> code (?)

Copy link

Contributor Author

@filipesilva filipesilva May 10, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

aio/content/guide/third-party-lib.md Outdated

Copy link

Member

@gkalpak gkalpak May 2, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

were followed copied onto the same file file --> ?

Copy link

Contributor Author

@filipesilva filipesilva May 10, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

aio/content/guide/third-party-lib.md Outdated

Copy link

Member

@gkalpak gkalpak May 2, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link is invalid. Is the project supposed to be created later?

Copy link

Contributor Author

@filipesilva filipesilva May 10, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct, for now it is in https://github.com/filipesilva/angular-quickstart-lib. When this guide is approved we can move the codebase under the Angular org.

aio/content/guide/third-party-lib.md Outdated

Copy link

Member

@gkalpak gkalpak May 2, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong link. It should be guide/third-party-lib#appendix-dependency-management.

Copy link

Contributor Author

@filipesilva filipesilva May 10, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

aio/content/guide/third-party-lib.md Outdated

Copy link

Member

@gkalpak gkalpak May 2, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

? --> . (?)

Copy link

Contributor Author

@filipesilva filipesilva May 10, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

aio/content/guide/third-party-lib.md Outdated

Copy link

Member

@gkalpak gkalpak May 2, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

app --> library

Copy link

Contributor Author

@filipesilva filipesilva May 10, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

aio/content/guide/third-party-lib.md Outdated

Copy link

Member

@gkalpak gkalpak May 2, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this line.

Copy link

Contributor Author

@filipesilva filipesilva May 10, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

aio/content/guide/third-party-lib.md Outdated

Copy link

Member

@gkalpak gkalpak May 2, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

peer Dependency --> peer dependency (?)

Copy link

Contributor Author

@filipesilva filipesilva May 10, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@wardbell wardbell added comp: aio and removed cla: yes labels

May 4, 2017

This was referenced May 5, 2017

Closed

"Please add a @NgModule annotation." error with AOT, full path vs short package.json main angular/angular-cli#6239

Closed

@FriOne

Copy link

FriOne commented May 10, 2017 •

edited

Loading

@filipesilva It would be nice to have a seed on github for this instead of text(or both). Thanks, It should help me to solve a problem.

Copy link

Contributor Author

filipesilva commented May 10, 2017

@FriOne the seed is temporarily at https://github.com/filipesilva/angular-quickstart-lib

@googlebot googlebot added the cla: yes label

May 10, 2017

Library with Typescript files fails to compile in AOT angular/angular-cli#6228

Copy link

Contributor Author

filipesilva commented May 10, 2017

Thank you for the review @gkalpak, lots of improvements there.

This was referenced May 11, 2017

Closed

[Feature] Create boilerplate for library angular/angular-cli#1692

Closed

@tomwanzek tomwanzek mentioned this pull request

May 16, 2017

Fails when use systemjs.config.js tomwanzek/d3-ng2-service#27

Closed

@ajcrites ajcrites mentioned this pull request

May 18, 2017

Built module distribution cannot be imported to other modules angular/angular-cli#6378

Closed

@danwulff

Copy link

danwulff commented May 25, 2017

I'm looking forward to this being merged and the quickstart-lib codebase being added to @angular.

@robwormald robwormald mentioned this pull request

May 31, 2017

[RFC] Library Support and Boilerplate Comment Thread angular/angular-cli#6510

Closed

@rjcorwin rjcorwin mentioned this pull request

May 31, 2017

Add code reuse FAQ to NG Module Guide #17129

Closed

3 tasks

nathanosdev

nathanosdev reviewed

Jun 3, 2017

aio/content/guide/third-party-lib.md Outdated

Copy link

@nathanosdev nathanosdev Jun 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a comma after 'publishing', otherwise the sentence can be confusing the first time it is read.

nathanosdev

nathanosdev reviewed

Jun 3, 2017

aio/content/guide/third-party-lib.md Outdated

Copy link

@nathanosdev nathanosdev Jun 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All mentions of 'meta data' here are inconsistent with references to 'metadata' elsewhere in the document. It should be 'metadata' everywhere.

@wardbell wardbell added area: packaging area: build & ci area: core and removed comp: aio labels

Jun 21, 2017

austince

austince reviewed

Jul 20, 2017

import seed project test-editor/deprecated-web-workspace-navigator#1

aio/content/guide/third-party-lib.md Outdated

Copy link

@austince austince Jul 20, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: are correctly build: -> are correctly built:

@franzbecker franzbecker mentioned this pull request

Jul 25, 2017

Merged

filipesilva added 3 commits

July 26, 2017 12:54


 add nav and dummy file

71f652b


 add base jade

4c42ae8


 add auto converted

0d0f1cd

filipesilva added 4 commits

July 26, 2017 12:54


 fix tables and filetree

d09b402


 add title/intro

f2d632f


 review content

c5d11f9

update the link parts for angular-cli and update to ngrx v4 benorama/ngrx-demo-apps#13


 incorporate @gkalpak 's feedback

97c6e83

@mhevery mhevery force-pushed the new-cb-third-party-lib branch from fe1d5c9 to 97c6e83 Compare

July 26, 2017 19:54

@axtho axtho mentioned this pull request

Aug 11, 2017

Closed

@ebtc ebtc mentioned this pull request

Aug 15, 2017

core(bug): adapt to latest cli digitaldeacon/memberhive#149

Closed

@lazarljubenovic lazarljubenovic mentioned this pull request

Sep 16, 2017

Use the Angular Package Format sebholstein/angular-google-maps#1157

Closed

@johnpapa

Copy link

Contributor

johnpapa commented Oct 9, 2017

What is the status on this? Would love to have official Angular team guidance on creating these library apps.

@IgorMinar

Copy link

Contributor

IgorMinar commented Feb 6, 2018

@filipesilva should we try to resurrect this guide and reuse it for the docs we'll need for the upcoming library support in CLI? or should we close this PR?

cc: @jenniferfell