Vector push_back causing Unhandled exception

Question

Everything is working until the compiler tries to perform the push_back operation. in the if condition proper values are being returned.
I have declared items as:

vector<int> items; // inside the header file.

//inside the .cpp file

void MsPs::findnSort()
{
 for(int i = 1; i<50 ; i++)
 {
 string temp = static_cast<ostringstream*>( &(ostringstream() << i) )->str(); // TO convert int i to a string temp
 if(findSupport(temp) >= MIS[i])
 {
 items.push_back(i);
 }
 }
}

the following error pops up:

Unhandled exception at 0x5052ad4a (msvcp100d.dll) in PrefixScan.exe: 0xC0000005: Access violation reading location 0x3d4cccd1.

PS: I have one more function using the push_back operation and there it's working fine.

Can anyone help me with this?

Even this gives the same error:

void MsPs::findnSort()
{
 for(int i = 1; i<50 ; i++)
 {
 items.push_back(i);
 }
}

• billz: what's the size of MIS?
• Adroit: Its size is 50, but while debugging, the code isn't going through even the first pass.
• billz: Memory is corrupted somewhere else, use debugger to see the call stack, should find something wrong
• Brett Hale: Why do you declare vector<int> items in the header file? Is it a shared header? Where is the vector actually instanced?
• Brett Hale: @ChrisHayden. No, it will not be a static instance - it will be an exported symbol in every translation unit that includes the header.

Answer 1

I think the issue is that the ostringstream is destructed when the static cast returns. Thus your pointer is dangling when str() is called. Try this instead:

void MsPs::findnSort()
{
 for(int i = 1; i<50 ; i++)
 {
 ostringstream blah;
 string temp = (blah << i).str();
 if(findSupport(temp) >= MIS[i])
 {
 items.push_back(i);
 }
 }
}

• Adroit: Eventhis is giving the same error: void MsPs::findnSort() { for(int i = 1; i<50 ; i++) { items.push_back(i); } }
• ildjarn: @AdRoiT : Sounds to me like you're calling findnSort on a null or otherwise invalid pointer to an MsPs object.