openstack/ironic-python-agent - ironic-python-agent - OpenDev: Free Software Needs Free Tools

Migrated the existing lints to pre-commit and switched some over to ruff
to follow the changes that have landed in the ironic repo.
Change-Id: I361ca1b8d4ac9738f9c45ba6a87c377f5aca22a8
Signed-off-by: Doug Goldstein <cardoe@cardoe.com>

In these cases two backticks must be used instead of one.
Change-Id: I85b00742a06ad1137a2d8f761432af97338995bb
Signed-off-by: Doug Goldstein <cardoe@cardoe.com>

flake8 checks recommend avoiding f-strings.
Change-Id: I1636cb45c73463b9b1d70ad784582beca277af4a
Signed-off-by: Doug Goldstein <cardoe@cardoe.com>

Fix this pep8 violation.
Change-Id: Ia69382a501791e3d11c045278c72073849cee20c
Signed-off-by: Doug Goldstein <cardoe@cardoe.com>

Change-Id: If3c8ed77587e4f36e6e9912c66eb9cd66700d515

Prevents the UnboundLocalError in erase_devices_express clean step.
Closes-Bug: #2095499
Change-Id: I01ce5005a62638ff960d2a75f225f882b2d56973

Debug messages from modprobe failing to load ipmi drivers can
be confusing and they do not add anything since they're
not really errors.
This patch silence the message in the logs.
Change-Id: I7452bc9e56148e3d423be92f384ff9aeffbe88d7

Related-Change: #939500
Change-Id: Id54f5bedd5c79c587bc4484914a8eb492e018010

Fail without retries when Errno 28 - "No space left
on device" error is encountered.
Closes-Bug: #2094854
Change-Id: Ie84b422916ddc02f2474164fe3da083324ef4824

Follow-up to 939340 to add a release note about the bug-fix.
Change-Id: I202f22d40776ab5d3245b8e14021d1404a9f478d

Use just md<index> as the default volume name if a volume name is not defined.
The original change (https://review.opendev.org/c/openstack/ironic-python-agent/+/853182)
introduced an error:
mdadm: Value "/dev/md0" cannot be set as name. Reason: Not POSIX compatible.\n
This change fixes it.
Closes-Bug: #2073406
Change-Id: Ic8bd473801fcb92fc814f6ad4e1d6dc316783bf3

ironic-lib is being retired; this change imports any used code from
ironic-lib and updates references.
This contains some changes to how we throw exceptions; aligning
ironic-lib code with IPA practice to have all exceptions be a RESTError.
This also allows us to remove code around serializing ironic-lib
exceptions.
Change-Id: I137340ce6820c68d8e0f1a32668151bba7b1ddd7

Adds support for running burnin tests on GPUs
using gpu-burn[1]. Also refactors stress-ng code
to be a bit cleaner.
Requires gpu-burn to be pre-installed within the IPA.
* https://github.com/wilicc/gpu-burn
Co-Authored-By: Scott Solkhon <scottsolkhon@gmail.com>
Closes-Bug: #2069085
Change-Id: I8f8cace6ebc2b7f1c245c82a64609cdfc1c492f9

The crypt module was removed in Python 3.13 . Replace the module by
new methods from oslo_utils.secretutils .
Closes-Bug: #2083955
Change-Id: I61060fc13aabc8116c3d0f8ad50ee8c415675f31

Update the 2023.1 release notes configuration to build from
unmaintained/2023.1.
Change-Id: I0d8b1773367a61b326b5a6ff86ac1f126b15099b

Extended the function that expose BMC MAC address in inventory data
for an IPv6 only interface.
Previously, if no IPv4 address was configured, no mac address was exposed.
Change-Id: I93e49d308cfd63be1c09749ced4428a87a3daff9

To support a safer take-over from the provisioning to the tenant network
for hardware that cannot be powered off, this change introduces a new
command system.lockdown. When invoked, it stops the API, the heartbeater
and disables all network interfaces (if possible).
Partial-Bug: #2077432
Change-Id: I211fc64a46226127b0d82ab458029b3c702b3f74

This is largely required for the future lockdown command but can also be
used before the normal shutdown, especially in the sync command which is
currently used before an out-of-band shutdown command is issued.
In addition to a plain sync, the new command also tells the kernel to
drop its cached and issues a low-level sync command to each block
device.
Partial-Bug: #2077432
Change-Id: I3fc87b20bc5387a466b24ebc19b9982e4e368d20

We are phasing out use of ironic-lib, and as such are removing the
metrics module from it. However, due to it's requirement of having
a statsd instance on the same subnet as the agent and there being no
support for prometheus exporting of metrics from IPA, these metrics are
no longer valuable (in the agent).
We are vendoring the module for the deprecation in order to facilitate
its removal from ironic-lib.
Change-Id: Ie50e078bc3f78d65cfa53680dc4116d1119ce155

It's clear the docstrings intended to indicate ProtectedDeviceError, but
instead indicate ProtectedDeviceFound.
This clears up the documentation to assist deployers trying to implement
hardware managers.
Change-Id: Iea534f58aeec60b3862099c1d89be829654a54c1

* The dd and is_http_url code is trivial, inline it.
* Migrate mounted (cannot be used in Ironic since it requires root).
* Remove the leftovers of run_as_root.
Change-Id: Ic6b117e34ccc7f55ebac5f808d2765305c4b317f

We traditionally have not done any translations for IPA, but some of the
code carried over from ironic_lib -- as well as a single hardware
manager -- were using the i18n wrappers. This removes them from
everywhere for consistency.
Change-Id: I85a607d7cfb50d605cc62ac8c5e3937802b4d2af

- Removes unused methods from disk_utils
- Unifies all image writing via populate_image
Change-Id: I860744458e52a45a4cb2882e4a59e0db9fbcb93d

Python 3.8 was removed from the tested runtimes for 2024.2[1] and has
not been tested since then.
Also add Python 3.12 which is part of the tested runtimes for 2025.1.
Now unit tests job with Python 3.12 is voting.
[1] https://governance.openstack.org/tc/reference/runtimes/2024.2.html
Change-Id: Id314b4453d81dcab806768e3c7ab5dc050a35136

``logical_sectors`` and ``physical_sectors`` sizes are now captured for
each hardware info ``disks`` entry, and also logged for ``lsblk`` calls.
This will be increasingly useful as storage devices with 4096 byte
sector sizes become more common.
Change-Id: I80b6b137f6e3071d9b8a4c1abe14416249aed9ac

Change-Id: Ia299f19f6348c35f6052efc78c7cb6b3093703ba

I have a case where a user provided the checksum URL with SHA256
checksums, while Metal3 defaulted os_hash_algo to "md5". We're going
to change the Metal3 defaults in the next API version, but for now let
us issue a clear warning in such case.
Closes-Bug: #2085331
Change-Id: Ie4e62a378dc4a2089944f4302df3a8671b7c960f

This replaces the copied-in version of format_inspector with the shared
version located in oslo.utils.
Change-Id: I62b3876f4507f28c8582cd4ba80e9f7c4e0b71ef

pip 23.1 removed the "setup.py install" for projects that do not have
their own pyproject.toml by having a hardcoded one within pip.
To address that, this change adds the minimal pyproject.toml
to enable pbr to be properly used to build editable wheels.
See https://pip.pypa.io/en/stable/news/#v23-1
and https://github.com/pypa/pip/issues/8368 for more info.
Change-Id: I76c5a8269628c4f081c4627f222c2d535534e832
Signed-off-by: Doug Goldstein <cardoe@cardoe.com>