openstack/ironic-python-agent - ironic-python-agent - OpenDev: Free Software Needs Free Tools

Change-Id: I4c28ee1bcbafba1cb2bab00463fe4354cd6ec25f

Bump IPA container to use trusty. This gives us a newer version of pip
which is required to install newer requirements that are packaged as
wheels.
Only other change to dockerfile is to ensure python 3 is
removed, in order to avoid raising the size of the container. After this
patch, the agent image goes up in size 3M, which is managable.
Change-Id: I11f39fadb87d42dd15885e6afc63df2c927ce771

Two reasons:
1) Use a build that is marked stable
2) Fixes an issue where boot hangs for minutes on updating CA
 things, which enables much faster deploy times.
Change-Id: Ic7fca96f0dfe87065e2df5feaf2c29efc662a0e1

Openstack global requirements updated to specify version 1 only, and we
only supported version 2.
Change-Id: Iee97e4b14cae00238028ef936d2f96fbc8e2604c

While auditing our dependencies in antipiation of DIB elements being
created, I found these dependencies not being explicitly installed by
docker. We should explicitly install them even if we expect them to
exist in the base image.
Change-Id: I38ec7167ae24b9abbda08cbbbdd55205612b7288

The previous implementation of list_block_devices used blockdev,
which would list partitions, software RAID and other devices as block devices.
By switching to lsblk, the agent can filter down to only physical block
devices, which is all the agent cares about for any of its operations.
This change adds two new fields to the BlockDevice class: model, a string of
the block devices reported model, and rotational, a boolean representing a
spinning disk (True) or a solid state disk (False). This data can be useful
for vendor hardware managers.
Change-Id: I385c3bb378c2c49385bca14a1d7efa074933becf
Closes-Bug: 1344351

Finding an IPv4 address to advertise fails and crashes if the
interface exists but has no valid IPs. This can be fixed by
adding KeyError to the exceptions caught.
Change-Id: I60204427ec5201696d02c5c26f4b43a00d794413
Closes-Bug: #1342448 

http://coreos.com/docs/cluster-management/setup/cloudinit-cloud-config/
describes how to use coreos-cloudinit to configure a node. Migrate to
using this instead of a single BASH script (which is deprecated).
This also means we need the latest version of CoreOS, so I've updated
coreos-oem-inject.py to pull from the most recent copies, and this
includes moving to the amd64-usr builds.
Change-Id: I620b8fec1bfc5d58b560434d17b4f617734fadb8

This script needs plumbum and requests, which are not installed by
default on bare-trusty.
Change-Id: I6bf1ebe66afcbbf47c5d9fe96d1a2b1b889882de

When building, `make` ends up calling `docker`, which needs to be
done via sudo. This runs make with sudo.
Change-Id: I49558dff3a00e1795d3fe0489a2ff183f00e6183

Helps debug post job.
Change-Id: Ia30a8b5511dc087ddd1ecdbfe8eb3ca1e63a0ad5

This changes the email in setup.cfg from an internal Rackspace
email to the openstack-dev list, and the author to OpenStack.
Change-Id: Iebd652c157ba639c72898b7554a23fe9bed77c22

Some people use metadata services, we should allow instances to be created without configdrive.
Change-Id: I5eb64b33291d6b975cf19357c04bf85066e4e3e8

We now do builds of the IPA CoreOS ramdisk in the post script. (Ref:
openstack-infra/config/tree/modules/openstack_project/files/
jenkins_job_builder/config/ironic-python-agent-jobs.yaml)
We should store the build script for this in the local repo so we can
modify it as needed without needing commits to openstack-infra/config.
Change-Id: I92655c0552179613c23b129d1e2dce2ef1643391

Change-Id: I88c642a24fb032b6e0920c8ba378127f8e12116c
Closes-Bug: 1332741

Because IPA now detects what IP to advertise, specifying this in the PXE
config should no longer be a recommended default.
Change-Id: I3a854fd07cd7987425288b61fd6eeac925db0bff

Exceptions raised due to processutils.execute() failing now include
stdout and stderr.
Change-Id: Id5d1b5bc51d377f9f3c338cd7303ea800f76e5cd

This:
 - includes a link to new gate-built images
 - updates the kernel command line options (none needed in newer
 images)
Change-Id: I79e9a0ab7de1dc61dd035bebf81c87136e4c3202

These comments were left in write_image.sh from the 'teeth-agent' days
when these were split into two scripts. I moved the comment into the
correct script and clarified what it means.
Change-Id: Iccdcd925be5c94d993d8125534264f496de4594f

This cleanup command was invalid. Not removing the apt lists adds a few
unneeded megabytes to the agent image.
Change-Id: I55ad4434d20a8984ea4cf5866360fd2622d811f4

Requests defaults to keeping 10 connections to the API alive. This
seems excessive, reduce it to 2.
Change-Id: Iac67fd4d855388d2671da3b7258b31d1eead77a9

The agent attempts to sort the HardwareManager implementations found
by stevedore in order of suitability. This patch fixes a bug in the
sorting order that caused the GenericHardwareManager to always be
loaded.
Fixes bug 1327923
Change-Id: I1cc20e5351a704325f0cf41dab205c9164799f6a

Add tests around cache_image functionality to cover other cases:
- A image is already cached
- A image is already cached but we use the parameter force to refresh it.
Change-Id: I9739c2e0d29091d29fa170cf04d953184b8cb54d
Partial-Bug: #1326849 

The test test_cache_image_success is (bad) duplicate of the
test test_cache_image
The test is trying to retrieve a real url and saving it into
a block device. Mock several calls to avoid this behavior and
and assert that the cached image is properly saved.
Change-Id: Ie2ff5931cc77e5cdd1621c652d73a62fed0b69a6
Partial-Bug: #1326849 

Logging statement says it's 'imaging' to RAW, when in reality it's a
conversion.
Change-Id: I80d112062f51a6ccc932aeb71ec05042edb09884

Previously this code was calling processutils.execute incorrectly,
expecting it to return the exit code. This change:
* fixes calls to processutils.execute
* fixes related tests
Change-Id: I3343f104a5a8200d53bd87a8799ff918e375b17f

When we have just written out a whole disk image, if we do not run
partprobe none of the new partitions show up in blkid, therefore even
images with a built-in configdrive partition will have one created
Change-Id: I6ec98dc237b42bfe94ce79cf84d155332335c9f6

This tests an async function, where exceptions will not bubble up
to the caller. So, we need to check the async result's command_status
attribute in order to make sure the call succeeded.
Change-Id: If8c529943acc794252778280a5fadf2c7860eb0d

During the first heartbeat, the heartbeater asks the agent to check
its advertised address; if the advertised IP is still the default
(None), the agent tries to replace it with the IP of the first network
interface it finds. If it fails to find either a network interface or
an IP address, the agent raises an exception.
Change-Id: I6d435d39e99ed0ff5c8b4883b6aa0b356f6cb4ae
Closes-Bug: #1309110 

When using set -e, if you have a command fail, even when setting a
variable, it causes the node to fail. I have removed set -e and checked
error state where unexpected everywhere. I also added additional
logging.
Closes-Bug: #1326326
Change-Id: I7d2568c3693b9c486672e4322c7f01622aeba875

Expose an async decom.erase_hardware command in the API. Executing
this command simply calls erase_devices on the loaded HardwareManager
implementation.
Change-Id: I238264a4d5903200ad6a30d82b61804c1e3f5916

Add erase_devices method to the HardwareManager class. By default this
method iterates block devices, and calls a new abstract
erase_block_device method for each device. This patch includes a
simple implementation of erase_block_device on the
GenericHardwareManager which attempts to issue an ATA secure erase on
supported devices.
Change-Id: I81da065395b8785f636f1b0a0d60c9f1c045441e

The HardwareManager class was missing a few abstract method
declarations which it is expected to have. Add those.
Change-Id: I1d07b7f08a4fc23929bc09f65b897fdfa0da1770

This adds support for copying configdrives to disks that already have
partitions enabled and labeled for configdrives. This is neccessary for
supporting configdrives on partitioning schemes we don't support yet
(like GPT) or for some future agent iteration where we create partitions
separately.
Change-Id: Iee5b87d82be08febc495aaef3272ced4f2f32235

The readme, leftover from when this was teeth-agent, was still pointing
at the travis-ci build. I removed that build status and added a link to
Openstack How to Contribute wiki page, so people visiting the mirror on
Github know not to create pull requests.
Change-Id: I8a82eb0e04cc35425f7856b16568f191c4c54770

Removed creating separate extension manager for flow extension.
Instead, have made flow extension using the same extension manager
instance which is initialized in agent. It fixes circular
extension loading in stevedore.
Closes-Bug: #1316145
Change-Id: Id339f1876168a41ca43ba7473f3ff6949a233ef3