openstack/ironic-python-agent - ironic-python-agent - OpenDev: Free Software Needs Free Tools

Also disabling dstat in all focal based jobs because of
https://bugs.launchpad.net/ubuntu/+source/dstat/+bug/1866619
Plus including increase of alloc memory to increase job
success rate, original change from [1]
And re-enabling ipa-tempest-bios-ipmi-direct-src and
ipa-tempest-bios-ipmi-iscsi-src
[1] https://review.opendev.org/759765
Co-authored-by: Julia Kreger <juliaashleykreger@gmail.com>
Change-Id: Ia154745b71c17063eeaaabeb56950ab1cc9ce927

The standalone job at present has a high chance of failure
due to two separate things occuring:
1) The deployed nodes from raid tests can be left in a dirty state
 as the raid configuration remains and is chosen as the root
 device for the next deployment. IF this is chosen by any job,
 such as rescue or a deployment test that attempts to login,
 then the job fails with unable to ssh. The fix for this is
 in the ironic-tempest-plugin but we need to get other fixes
 into stablilize the gate first.
 https://review.opendev.org/#/c/757141/
2) Long running scenarios run in cleaning such as deployment with
 RAID in the standalone suite can encounter conditions where
 the conductor tries to send the next command along before the
 present configuration command has completed. An example is
 downloading the image is still running, while a heartbeat
 has occured in the background and the conductor then seeks
 to perform a second action. This then causes the entire
 deployment to fail, even though it was transitory.
 This should be a relatively easy fix.
 https://review.opendev.org/759906
Also disabling ipa-tempest-bios-ipmi-direct-src and
ipa-tempest-bios-ipmi-iscsi-src for the time being, will revert
in https://review.opendev.org/757812
Change-Id: I08c8c258587dd3786dfa92e7879a80c80971d7df

Versions of hacking from 3.1.0 until 4.0.0 NOT included are supposed
to require a safe version of flake8, so besides normale issues related
to minor version upgrades, we can safely use those versions.
Also forcing pycodestyle versions to be compatible with flake8 installed
by hacking.
Change-Id: Ifa2af7404f4cd85cffd29ed725278d04a7c5f8c6

Follow-up to https://review.opendev.org/#/c/756300/
Change-Id: Ibc6c044e24dde82928f19a9b9a7eaf68be53fb0e

Calling join() does not raise, we need to explicitly check the result.
Change-Id: I81d3d727af220c2b50358edab8139f07874611f0
Story: #2008240
Task: #41083 

Currently the test takes 5*5=25 seconds. Re-arrange the code so
that it's possible to change the retry delay in tests.
Change-Id: Ia559dad4bc656f8ad6b2cb8cb0137a97e2614db7

This is not a normal situation and is likely to cause problems.
Change-Id: Id0668fd160ac0539d85997e985f8c43d9da75c90

We don't have a really working way to detect root UUID for whole
disk images at the moment, which results in an ignored traceback
every time install_bootloader is called with whole disk images in
UEFI mode. Avoid it by skipping GRUB2 if root UUID is unknown.
Change-Id: I84245538f59c664b72d1cafbca8d61be0978f489

We can use focal here but we need to disable dstat because of
https://bugs.launchpad.net/ubuntu/+source/dstat/+bug/1866619
Change-Id: I2c013e871fc56aa0077656dfc76de9aad6bed83f

We'll keep using bionic as nodeset for certain jobs because of limitations
in DIB when building centos images.
DIB uses yum-tools to prepare the chroot environment, but the package is
not present in ubuntu focal because of lack of Python 2.x support.
Change-Id: I8635b7dfa6910c1721b89739d4d51fa7df488432

Upon md device creation, component devices are sometimes removed
immediately again due to a "disk failure". The disks seem healthy,
though. This patch re-adds compoenent devices in such cases to
prevent that the md device will remain in a degraded state (which
would cause issues later, e.g. during ESP creation).
Story: #2008164
Task: #40914
Change-Id: I2ac7cb4a546de84686d5c3435e850c14b3f6c1d7

This is an automatically generated patch to ensure unit testing
is in place for all the of the tested runtimes for wallaby.
See also the PTI in governance [1].
[1]: https://governance.openstack.org/tc/reference/project-testing-interface.html
Change-Id: Ib5cfc3be530851be8e426693c668f3ebcab2ecb3

Add file to the reno documentation build to show release notes for
stable/victoria.
Use pbr instruction to increment the minor version number
automatically so that master versions are higher than the versions on
stable/victoria.
Change-Id: Ia3696da8663c140504924b0a1cd23f9aaa517f0a
Sem-Ver: feature

Scanning the output of mdadm commands for RAID members will
miss component devices which are currently not part of the
RAID. For proper cleaning it is better to scan block devices
for a signature of the md device for which we would like to
get the components.
Story: #2008186
Task: #40947
Change-Id: Ib46612697851e36a16d272ccaeb0115106253863

Partions on the holder disk should only be deleted after
all RAID devices have been deleted. Otherwise, super blocks
on partitions which reside on the same disks cannot be cleaned.
Story: #2008199
Task: #40979
Change-Id: I19293f5b992cd1fa68957d6f306dcec8f3b7a820

Story: #2007214
Task: #40945
Change-Id: I1a930a0e52ab860edcd597df4d95a4e4eb51da96

Currently, IntelCnaHardwareManager inherits GenericHardwareManager
which makes it a new "GenericHardwareManager" with "MAINLINE" priority.
This causes all other hardware-managers with lower priority than
"MAINLINE" never be used. To fix this, make IntelCnaHardwareManager
inherit basic HardwareManager.
Change-Id: I28b665d8841b0b2e83b132e1f25df95e03e7ba10
Story: 2008142
Task: 40882

Heartbeating in IPA has used select.poll() for years to workaround
a bug where changing the time in the ramdisk could cause heartbeats
to stop and never resume.
Now that IPA syncs time at start and exit, this workaround is no
longer needed. So instead, we'll revert to using threading.Event()
in order to make the code simpler and easier to understand.
Since we need this to be an eventlet-event, and not a standard-thread
event, also monkey_patch threading.
Additionally, there were a few completely unused backoff interval
values set, that were never applied. In respect of maintaining the
5+ years old behavior of not doing error backoffs, that code was
removed instead of being made to work.
Change-Id: Ibcde99de64bb7e95d5df63a42a4ca4999f0c4c9b

The IPA images we presently build/use for centos are
now smaller than their peak size a few months ago.
As such, we should be able to reduce that memory footprint
and still execcute all of the necessary tests without any
issues.
Also increases the amount of swap to 8GB as the infra
default is now 1GB.
Change-Id: I5705f1f2504803a049ed88a0d8b1d6d0bbccf9e4

I can never remember if it's "device" or "devices".
Change-Id: Ib1388f0425ec4c02fbeacb26ad55bc90b0f3483c

Also make this API return a proper HTTP code (409 instead of 500).
Change-Id: I5d86878b5ed6142ed2630adee78c0867c49b663f

Change-Id: I94657967763f058fccd4f19656925d02cd8973b8

A transitory connection failure, such as one caused by
a port being held down for traffic forwarding, can experience
intermittent connectivity failures which result in failed
introspections.
Now the agent retries.
Change-Id: I72c5e3aca000d3854a17f8a461b1a2935e5c0d9b

Adds a new flag (on by default) that enables generating a TLS
certificate and sending it to ironic via heartbeat. Whether
ironic supports auto-generated certificates is determined by
checking its API version.
Change-Id: I01f83dd04cfec2adc9e2a6b9c531391773ed36e5
Depends-On: https://review.opendev.org/747136
Depends-On: https://review.opendev.org/749975
Story: #2007214
Task: #40604 

Makes sure heartbeats can send versions higher than one required for
tokens while also making sure we never send a version we don't know.
Also makes code easier to understand.
Change-Id: Ice1e7d45ea90c9fd8220c4b94e691b6015e23074

Change-Id: I98e087f85e166da02890828054ed46ec9177eeb5

The node lookup code added in change
I27201319f31cdc01605a3c5ae9ef4b4218e4a3f6
was slightly broken in that we call a method
with a keyword arguemnt which doesn't exist.
uuid versus node_uuid.
It happens, it is a quick fix!
Spotted on a metalsmith job:
[-] Agent is requesting to perform an explicit node cache update.
 This is to pickup any chanages in the cache before deployment.
[-] Failed to update node cache. Error lookup_node() got an
 unexpected keyword argument 'uuid'
Change-Id: I59ecec65707a2f03918b233f1925395ebe59b8c4

Apparently, functional-py36 just runs unit tests.
Fix the test that has regressed in the meantime and make it voting
so that we don't regress again.
Change-Id: Id5efe89a12a00c27e6299380a51cdb840285d691