-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
feat: add OkHandler support in gateway EventHandler for HTTP responses #5070
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
guonaihong
wants to merge
9
commits into
zeromicro:master
from
guonaihong:supports-httpx.OkHandler-callbacks
Open
feat: add OkHandler support in gateway EventHandler for HTTP responses #5070
guonaihong
wants to merge
9
commits into
zeromicro:master
from
guonaihong:supports-httpx.OkHandler-callbacks
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
背景:
我在使用gateway(http) -> grpc的过程中,发现httpx.SetOkHandler这个函数不生效(对立函数httpx.SetErrorHandler是好的), 经分析目前的实现中没有设置勾子函数。此pr是为了让该函数生效。