-
Notifications
You must be signed in to change notification settings - Fork 220
feat: improve HTML semantics and buttons animation #428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@SebastianL-dev
SebastianL-dev
commented
Jan 23, 2025
- Improved HTML semantics and fix buttons hover transition.
Hi! Could we see how it look now?
Hey, the design its the same, i just fixed some HTML semantics, and the buttons transitions its better, before all buttons have no transitions, now have fade transition on hover.
Screen.Recording.2025年01月24日.213418.mp4
It's a little change but i think that look much better.
Doesn't it break the initial animations though?
Nope, it doesn't, you can see it in the video 😊
Hey, nice work! This change seems fine for the most part, but it does break the color of the "Start Exploring" button. On the main version, it's dark (to contrast it from the "Download" button), but on your version, it's light. Shouldn't be too hard to fix.
There might be some other color issues too, but that's the main one that I noticed.
Hey, sorry for that, i didn't realize about that, i will fix it and update this pull request, thank you. 😊
- Fixed buttons transitions, now looks better and don't break the contrast in buttons.
Screen.Recording.2025年01月27日.135619.mp4
Hey, i fixed the transitions, now the transitions looks better and it doesn't break the contrast.