-
Notifications
You must be signed in to change notification settings - Fork 450
fix(components/useGeographies): allow SSR with JSON #337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch updates the `useGeographies` hook to allow server-side rendering when passing in a static JS object (e.g. from a local JSON file). This hook will still prevent trying to fetch external geography data when rendering server-side.
nicholaschiang
added a commit
to nicholaschiang/dolce
that referenced
this pull request
Aug 10, 2023
This patch fixes a server-client error that was occurring because `react-simple-maps` does not fully support server-side rendering. I should fix this upstream, but this is a temporary fix to avoid surfacing the error message in my application. Ref: zcreativelabs/react-simple-maps#337
nicholaschiang
added a commit
to nicholaschiang/dolce
that referenced
this pull request
Aug 10, 2023
This patch fixes a server-client error that was occurring because `react-simple-maps` does not fully support server-side rendering. I should fix this upstream, but this is a temporary fix to avoid surfacing the error message in my application. Ref: zcreativelabs/react-simple-maps#337
nicholaschiang
added a commit
to nicholaschiang/dolce
that referenced
this pull request
Aug 10, 2023
This patch fixes a server-client error that was occurring because `react-simple-maps` does not fully support server-side rendering. I should fix this upstream, but this is a temporary fix to avoid surfacing the error message in my application. Ref: zcreativelabs/react-simple-maps#337
nicholaschiang
added a commit
to nicholaschiang/dolce
that referenced
this pull request
Aug 11, 2023
This patch fixes a server-client error that was occurring because `react-simple-maps` does not fully support server-side rendering. I should fix this upstream, but this is a temporary fix to avoid surfacing the error message in my application. Ref: zcreativelabs/react-simple-maps#337
nicholaschiang
added a commit
to nicholaschiang/dolce
that referenced
this pull request
Aug 11, 2023
This patch fixes a server-client error that was occurring because `react-simple-maps` does not fully support server-side rendering. I should fix this upstream, but this is a temporary fix to avoid surfacing the error message in my application. Ref: zcreativelabs/react-simple-maps#337
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch updates the
useGeographieshook to allow server-side rendering when passing in a static JS object (e.g. from a local JSON file). This hook will still prevent trying to fetch external geography data when rendering server-side.