-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Show the PagerTabStripViewController with the selected sub-controller (default tab) #692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@alexookah
alexookah
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks ok
@xmartlabs please merge this PL into master.
Test:
in viewDidLoad
moveToViewController(at: indexTo, animated: false)
super.viewDidLoad()
Hello @alexookah
Is it ok now or I messed it up? My update works as expected if I test with/without it the example app after the merge (critical to call moveToViewCmoveToViewController(at: indexTo, animated: false) before the super.viewDidLoad() )
alexookah
commented
May 12, 2019
Hello @alexookah
Is it ok now or I messed it up? My update works as expected if I test with/without it the example app after the merge (critical to callmoveToViewCmoveToViewController(at: indexTo, animated: false)before thesuper.viewDidLoad())
it's ok. just added how to test it so that this get's merged into master.
@zhpengkun
zhpengkun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for me.
@zhpengkun
zhpengkun
left a comment
•
edited
Loading
edited
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
zhpengkun
commented
Jul 15, 2019
@mtnbarreto Is this can be merged? Anyone?
juanbiberretta
commented
Jul 26, 2019
Would love to see this merged! :D
sroymeetup
commented
Jul 26, 2019
Would be nice to see this get merged! We have an issue in our app that depends on this fix.
Fix for another user case with sub-controllers switch #746 for anyone interested
@ElonPark
ElonPark
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Uh oh!
There was an error while loading. Please reload this page.
Solves the issue and another one