-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Refactor foreignID to use PostMetadataContainer #24951
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Open
+16
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kean
kean
commented
Oct 17, 2025
extension PostHelper {
@objc public static let foreignIDKey = "wp_jp_foreign_id"
@objc public static let foreignIDKey = PostMetadataContainer.Key.foreignID.rawValue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's still used in one more place – will address later.
Quality Gate Passed Quality Gate passed
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
App Icon📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
Configuration Release-Alpha
Build Number
29541 Version
PR #24951 Bundle ID
org.wordpress.alpha Commit f3d6613
Installation URL 3a76ptiqln3q8
App Icon📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
Configuration Release-Alpha
Build Number
29541 Version
PR #24951 Bundle ID
com.jetpack.alpha Commit f3d6613
Installation URL 6f5irr905qgn8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor
foreignIDto usePostMetadataContainerintroduced in #24946.It can be tested by setting a breakpoint and saving a post. We do have unit tests coverage as well.
Screenshot 2025年10月17日 at 11 19 27 AM