Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: add signal to EIP1193RequestOptions #3840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
deodad wants to merge 6 commits into wevm:main
base: main
Choose a base branch
Loading
from deodad:td/abort
Open

Conversation

Copy link
Contributor

@deodad deodad commented Aug 5, 2025

This PR address #1701. If the approach looks good I'll extrapolate to the rest of the actions where this makes sense.

MKRhere reacted with heart emoji
Copy link

changeset-bot bot commented Aug 5, 2025
edited
Loading

⚠️ No Changeset found

Latest commit: 63a7eca

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@tmm tmm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excited for this! Some random code style feedback.

Co-authored-by: tmm <tom@meagher.co>
Copy link
Contributor Author

deodad commented Aug 5, 2025

Excited for this! Some random code style feedback.

thanks—applied

Copy link
Member

jxom commented Aug 7, 2025

Happy to continue with the other Actions too.

Copy link
Contributor Author

deodad commented Aug 7, 2025
edited
Loading

I took an initial stab at it. It's ok but having done it this way it might more sense to figure out all the changes required for an action and then go through each one and apply all the changes:

  1. accept requestOptions
  2. make sure RequestErrorType is included in the error type
  3. update the docs page to include requestOptions

a couple others that I'm not sure about but seemed useful:

  1. add a test case to the actions tests for requestOptions. wasn't sure if adding to each action is worth it or too redudant
  2. explicit handling of request errors in catches. for actions that have extra handling that wrap errors in a specific error type would it make sense to check for AbortError or generally for non-base errors and instead immediately rethrow unwrapped?

Copy link

MKRhere commented Sep 9, 2025

Not to bother, but could we update this branch from main and avoid it going stale? I've been watching this PR eagerly :)

@tmm tmm force-pushed the main branch 3 times, most recently from 129b947 to 9ad3509 Compare September 19, 2025 19:48
@jxom jxom force-pushed the main branch 2 times, most recently from d78cf00 to b31cf2a Compare October 7, 2025 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tmm tmm tmm left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /