-
Notifications
You must be signed in to change notification settings - Fork 1.3k
fix: compute styles for mixed min and max breakpoints properly #5019
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
+216
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@TrySound
TrySound
changed the title
(削除) fix: sort mixed min and max breakpoints properly (削除ここまで)
(追記) fix: compute styles for mixed min and max breakpoints properly (追記ここまで)
Mar 19, 2025
kof
kof
approved these changes
Mar 19, 2025
Added a couple of tests with style engine to figure out proper sorting.
@TrySound
TrySound
force-pushed
the
fix-media
branch
from
March 20, 2025 06:40
f47071e to
d293854
Compare
@TrySound
TrySound
temporarily deployed
to
empty
March 20, 2025 06:45 — with
GitHub Actions
Inactive
@TrySound
TrySound
temporarily deployed
to
development
March 20, 2025 06:45 — with
GitHub Actions
Inactive
Was it not completed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a couple of tests with style engine to figure out proper sorting.