-
-
Notifications
You must be signed in to change notification settings - Fork 7.1k
fix(VTimePicker): separator size based on density #22136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
We need to admit that there is no support for density
in VTimePicker. Adding it because of separator is not really helping much. Typically, density is resolved by subtracting (see extracted list of Sass variables that control it). I wish we have at least give it a try to make VTimePicker aligned with all other components.
We need to admit that there is no support for
density
in VTimePicker. Adding it because of separator is not really helping much. Typically, density is resolved by subtracting (see extracted list of Sass variables that control it). I wish we have at least give it a try to make VTimePicker aligned with all other components.
I agree this is a hacky fix, however I thought it was worthwhile looking into because it looks terrible when you have a global density. Another idea would be to just force default density on the buttons
Maybe we can sync up on what density would look like for the time picker and plan out how it would go
-4, -8 ? demo
I was trying to align with the spec that changes sizes when using seconds... but maybe there is nothing to worry about. We can make it apply only to the "default" density.
-4, -8 ? demo
I was trying to align with the spec that changes sizes when using seconds... but maybe there is nothing to worry about. We can make it apply only to the "default" density.
I think the changes you pushed to the PR look good
Uh oh!
There was an error while loading. Please reload this page.
Description
fixes: #22056
Markup: