-
Notifications
You must be signed in to change notification settings - Fork 23
Allow parentheses in validation for value strings #62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... npm test requires it
...xample in Content Security Policy headers which get validated by this pattern
paulshryock
commented
Nov 11, 2021
Is anything blocking this from being merged?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I made this pull request to solve the issue in described in:
vercel/serve#649
In short:
serve
library can be used to set up security headers.Permissions-Policy
has a changed syntax which is currently rejected because it fails the schema validation imposed by this repository.to this pattern:
Also, I noticed that, after cloning and running
npm install
, I could not runnpm test
as yarn was not being installed. Therefore I added yarn as a development dependency topackage.json
.Best, Roel