Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Allow parentheses in validation for value strings #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
roelnoort wants to merge 2 commits into vercel:main
base: main
Choose a base branch
Loading
from roelnoort:allow_parentheses

Conversation

Copy link

@roelnoort roelnoort commented Apr 12, 2021

Hi,

I made this pull request to solve the issue in described in:
vercel/serve#649

In short:

  1. The serve library can be used to set up security headers.
  2. One new header, the Permissions-Policy has a changed syntax which is currently rejected because it fails the schema validation imposed by this repository.
  3. The schema validation does not allow parentheses () to be used. I added this by changing this regex pattern:
"^[a-zA-Z0-9_!#$%&'*+.;/:, =^`|~-]+$"

to this pattern:

"^[a-zA-Z0-9_!#$%&()'*+.;/:, =^`|~-]+$"

Also, I noticed that, after cloning and running npm install, I could not run npm test as yarn was not being installed. Therefore I added yarn as a development dependency to package.json.

Best, Roel

paulshryock reacted with thumbs up emoji GuillermoBlasco, paulshryock, and rspineda reacted with heart emoji paulshryock reacted with rocket emoji
Copy link

Is anything blocking this from being merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /