Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: remove authentiacation cache #584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xdlbdy wants to merge 1 commit into vanus-labs:main
base: main
Choose a base branch
Loading
from xdlbdy:remove_cache

Conversation

Copy link
Contributor

@xdlbdy xdlbdy commented Mar 30, 2023

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Signed-off-by: xdlbdy <xdlbdy@gmail.com>
Copy link

codecov bot commented Mar 30, 2023

Codecov Report

Merging #584 (3d65f2d) into main (ee76217) will decrease coverage by 2.31%.
The diff coverage is 45.59%.

Additional details and impacted files

Impacted file tree graph

@@ Coverage Diff @@
## main #584 +/- ##
==========================================
- Coverage 57.07% 54.76% -2.31% 
==========================================
 Files 190 211 +21 
 Lines 15191 16920 +1729 
==========================================
+ Hits 8670 9266 +596 
- Misses 5884 6957 +1073 
- Partials 637 697 +60 
Impacted Files Coverage Δ
internal/controller/trigger/storage/storage.go 0.00% <ø> (ø)
internal/gateway/proxy/auth.go 0.00% <0.00%> (ø)
internal/gateway/proxy/deadletter.go 0.00% <0.00%> (ø)
internal/gateway/proxy/direct.go 15.84% <ø> (-57.50%) ⬇️
internal/gateway/proxy/proxy.go 23.23% <ø> (+0.14%) ⬆️
internal/gateway/proxy/reigister.go 100.00% <ø> (ø)
internal/gateway/proxy/util.go 0.00% <ø> (ø)
...nternal/primitive/authentication/authentication.go 36.95% <ø> (ø)
internal/primitive/authentication/client.go 0.00% <ø> (ø)
internal/primitive/authorization/action.go 0.00% <ø> (ø)
... and 73 more

... and 56 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba347ae...3d65f2d. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ifplusor ifplusor Awaiting requested review from ifplusor ifplusor is a code owner

@wenfengwang wenfengwang Awaiting requested review from wenfengwang

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

AltStyle によって変換されたページ (->オリジナル) /