-
Notifications
You must be signed in to change notification settings - Fork 67
Remove preventDefault from swipeable and tappable. #113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This was prevent carousel particles that contained clickable items from working properly on mobile devices. Removing preventDefault from both locations allows these items to response properly when clicked. No adverse behavior had been observed. Tested on a Pixel 2 phone monitored with chrome dev tools.
Hello Vadimkorr!
I was trying to make a carousel that had a call to action button in each particle, but I found that these hyperlinks were unclickable on mobile devices. I found issue #91 that described what I was seeing and @fnavarijo had already tracked down the root cause.
I removed the two preventDefault() calls in the swipeable and tappable interfaces and found that the hyperlinks were working now. I did some quick swiping and tapping on other areas and found that there seemed to be no adverse effects from removing preventDefault.
I understand that you specifically added these calls in their own commit, so maybe there is a reasoning that the rest of us are unaware of? If so, I hope we can discuss this in the review and maybe assist in coming up with a more robust fix if necessary.
Thanks!
Cory
Released in 1.0.20
Uh oh!
There was an error while loading. Please reload this page.
This was preventing carousel particles that contained clickable items from
working properly on mobile devices.
Removing preventDefault() from both locations allows these items to
response properly when clicked. No adverse behavior had been observed.
Tested on a Pixel 2 phone monitored with chrome dev tools.