-
Notifications
You must be signed in to change notification settings - Fork 17
Added Instance Method and Value Bindings #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
tserkov
commented
Oct 14, 2017
There are a couple issues with this pull request:
- You've edited the transpiled distribution file directly. Changes should be made to index.js, and then packaged by running
npm run buildto update dist/vue-scroll-reveal.js. - There's no need to break out each option. The entire
binding.valueis passed to ScrollReveal asoptions(see index.js#L7). - Adding a
$revealmethod to the global Vue object is outside the scope of a pure Vue directive.
Thanks!
Author
devanflaherty
commented
Oct 14, 2017
via email
Oh okay cool.
Still learning.
... On Sat, Oct 14, 2017 at 2:25 PM James ***@***.***> wrote:
There are a couple issues with this pull request:
- You've edited the transpiled distribution file directly. Changes
should be made to index.js, and then packaged by running npm run build
to update dist/vue-scroll-reveal.js.
- There's no need to break out each option. The entire binding.value
is passed to ScrollReveal as options (see index.js#L7
<https://github.com/tserkov/vue-scroll-reveal/blob/670fa68e12feeeb7ef59932852cdac59109c2bea/index.js#L7>
).
- Adding a $reveal method to the global Vue object is outside the
scope of a pure Vue directive.
Thanks!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#5 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACX_sY9I8G3NMBw3gZBpQOsU_hr0p5Nzks5ssRi6gaJpZM4P44Wg>
.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wanted to have a few more options via the directive, so I added some bindings.values to look for to set the options for the Scroll Reveal Instance.
Having these extra options and being able to create a SR Instance from my methods was super helpful, hoping it could help someone else as well.