Skip to content

Store: breaking ⚠️ set debug.advertise-compatibility-label t... #8509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open

Xaelias wants to merge 1 commit into thanos-io:main

from Xaelias:fix_-_adhoc_-_2025年10月02日_-_Set_debug.advertise-compatibility-label_to_false_by_default

Open

Store: breaking ⚠️ set debug.advertise-compatibility-label t... #8509

Changes from all commits

Commits

Show all changes

Select commit

Store: *breaking :warning:* set debug.advertise-compatibility-label t...

Xaelias Oct 2, 2025

File filter

Filter by extension

Conversations

Jump to

Jump to file

Failed to load files.

Loading

Diff view

Diff view

1 change: 1 addition & 0 deletions CHANGELOG.md

Show comments View file Open in desktop

Original file line number	Diff line number	Diff line change
Expand Up		@@ -15,6 +15,7 @@ We use breaking :warning: to mark changes that are not backward compatible (re
		- [#8334](https://github.com/thanos-io/thanos/pull/8334) Query: wait for initial endpoint discovery before becoming ready
		- [#8486](https://github.com/thanos-io/thanos/pull/8486) Receive: fix exemplar label corruption from Cap'n Proto memory references
		- [#8499](https://github.com/thanos-io/thanos/pull/8499) Query: support UTF-8 label names for the `/api/v1/label/:name/values` API.
	- [#8509](https://github.com/thanos-io/thanos/pull/8509) Store: breaking :warning: set debug.advertise-compatibility-label to false by default

		### Added

Expand Down

2 changes: 1 addition & 1 deletion cmd/thanos/store.go

Show comments View file Open in desktop

Original file line number	Diff line number	Diff line change
Expand Up		@@ -180,7 +180,7 @@ func (sc *storeConfig) registerFlag(cmd extkingpin.FlagClause) {
		Default("9999年12月31日T23:59:59Z").SetValue(&sc.filterConf.MaxTime)

		cmd.Flag("debug.advertise-compatibility-label", "If true, Store Gateway in addition to other labels, will advertise special \"@thanos_compatibility_store_type=store\" label set. This makes store Gateway compatible with Querier before 0.8.0").
	Hidden().Default("true").BoolVar(&sc.advertiseCompatibilityLabel)
	Hidden().Default("false").BoolVar(&sc.advertiseCompatibilityLabel)

		sc.selectorRelabelConf = *extkingpin.RegisterSelectorRelabelFlags(cmd)

Expand Down

Loading