-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
Fix lowercase+uppercase keys (camelCase/PascalCase) unexpectedly treated to kebab-case when using JavaScript config file #18115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@woohm402
woohm402
force-pushed
the
woohm402/20250523012613
branch
from
May 22, 2025 16:37
10ebcb2 to
adb9580
Compare
I haven’t thoroughly tested all possible edge cases, so there might be scenarios I missed.
If anything seems off or needs more coverage, I’d be happy to follow up 😀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Summary
Fixes #18114.
It Seems in
apply-config-to-theme.ts#keyPathToCssPropertyfunction the theme key is transformed as:.is replaced with-/([a-z])([A-Z])/is replaced with1ドル-2ドル.toLowerCase()However in
theme.ts#resolve, when failed to find exact key, it only replaces.is replaced with-It seems the second transformation step is missing in theme.ts#resolve, causing inconsistencies when using camelCase or PascalCase theme keys.
Test plan
All unit tests pass, including the new test case covering this behavior.