-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
fix: allow keyed {#each ...}
without as
#16963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 08a24f1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
pnpm add https://pkg.pr.new/svelte@16963
This wasn't quite right — the pattern
argument always needs to be present, even if it's just placeholder, otherwise the index argument is given in the wrong position.
Fixed that but in the course of adding a test realised that there's actually a very good reason not to do this — if the key function can't reference the item, then it can't do anything useful. So I think we should probably just forbid key functions for each
blocks without an as
clause
opened #16966
Closing because of #16966
Closes #16927.
We had assumed that all keyed
{#each ...}
blocks would have anas
clause, and didn't throw if this assumption failed, nor did we document this. This fixes that.Before submitting the PR, please make sure you do the following
feat:
,fix:
,chore:
, ordocs:
.packages/svelte/src
, add a changeset (npx changeset
).Tests and linting
pnpm test
and lint the project withpnpm lint