Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: allow keyed {#each ...} without as #16963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Ocean-OS wants to merge 2 commits into main from gh-16927
Closed

fix: allow keyed {#each ...} without as #16963

Ocean-OS wants to merge 2 commits into main from gh-16927

Conversation

Copy link
Member

@Ocean-OS Ocean-OS commented Oct 16, 2025

Closes #16927.
We had assumed that all keyed {#each ...} blocks would have an as clause, and didn't throw if this assumption failed, nor did we document this. This fixes that.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code within packages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Oct 16, 2025
edited
Loading

🦋 Changeset detected

Latest commit: 08a24f1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

Playground

pnpm add https://pkg.pr.new/svelte@16963

Copy link
Member

Rich-Harris commented Oct 16, 2025
edited
Loading

This wasn't quite right — the pattern argument always needs to be present, even if it's just placeholder, otherwise the index argument is given in the wrong position.

Fixed that but in the course of adding a test realised that there's actually a very good reason not to do this — if the key function can't reference the item, then it can't do anything useful. So I think we should probably just forbid key functions for each blocks without an as clause

Copy link
Member

opened #16966

Copy link
Member

Closing because of #16966

Ocean-OS reacted with thumbs up emoji

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

#each blocks without an item + key expression cause a runtime error

AltStyle によって変換されたページ (->オリジナル) /