Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: support for spreading function bindings #16607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jackgdll wants to merge 23 commits into sveltejs:main
base: main
Choose a base branch
Loading
from jackgdll:spread-function-bindings

Conversation

Copy link
Contributor

@jackgdll jackgdll commented Aug 12, 2025
edited
Loading

Closes: #16086

Adds support for spreading function bindings using ... syntax.

Before:

<script>
 const [get, set] = bindLowerCase(value);
</script>
<input bind:value={get, set} />

After:

<script>
 function bindLowerCase(value) {
 return [
 () => value.toLowerCase(),
 (v) => value = v.toLowerCase()
 ];
 }
</script>
<input bind:value={...bindLowerCase(value)} />

Works with [get, set] tuples.
If either get or set is nullish it's a noop.
If either get or set is not a function a runtime error is thrown.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code within packages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

ivenuss reacted with thumbs up emoji
Copy link

changeset-bot bot commented Aug 12, 2025
edited
Loading

🦋 Changeset detected

Latest commit: 2825bce

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

Copy link
Contributor

Playground

pnpm add https://pkg.pr.new/svelte@16607

@jackgdll jackgdll marked this pull request as draft August 12, 2025 19:44
@jackgdll jackgdll marked this pull request as ready for review August 12, 2025 20:10
Copy link
Member

Thank you! I think this would need to run inside an effect, or use a derived, since otherwise something like this...

<input bind:value={...binding(validation, defaults)} />

...wouldn't update if validation or defaults did. Or to take an example similar to the one above, toggling uppercase has no effect, and it feels like it probably ought to.

Copy link
Contributor Author

jackgdll commented Sep 2, 2025

Thanks! I wrapped the call to $.validate_spread_bindings in a derived and added a test for this case

Copy link
Member

Thanks — I actually missed before that both [get, set] and { get, set } are supported. To be honest I don't love this, it feels messy to me. I've never regretted having a stricter contract (and certainly not starting with a stricter contract), so personally I'd much rather it just be [get, set]. Having multiple ways to do something feels like it's just giving people options but in reality it creates confusion and makes the API as a whole less legible.

A nice bonus: no validate_spread_bindings required in prod, we can just use the array directly (albeit with optional chaining at the callsite). Thoughts?

Copy link
Contributor Author

Good point, having a stricter contract makes sense and makes the implementation and tests simpler, as well as being able to remove validate_spread_bindings in prod like you mentioned.
I've removed support for { get, set } and adjusted the tests and docs.

One quirk of the implementation that I noticed is that things like bind:value={...1}, bind:value={...true}, and bind:value={...{}} are all considered valid noops since 1[0] === undefined which seems like confusing behaviour.

Maybe validate_spread_bindings should throw if the expression isn't an array, or at least if it isn't iterable.
Or maybe this is something that the typescript compiler should be flagging. WDYT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Allow spreading function bindings

AltStyle によって変換されたページ (->オリジナル) /