Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix(deps): update dependency electron-updater to v6 [security] #5136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
renovate wants to merge 1 commit into master
base: master
Choose a base branch
Loading
from renovate/npm-electron-updater-vulnerability

Conversation

Copy link
Contributor

@renovate renovate bot commented Sep 25, 2024
edited
Loading

This PR contains the following updates:

Package Change Age Confidence
electron-updater (source) ^4.2.0 -> ^6.0.0 age confidence

Warning

Some dependencies could not be looked up. Check the Dependency Dashboard for more information.

GitHub Vulnerability Alerts

CVE-2024-39698

Observations

The file packages/electron-updater/src/windowsExecutableCodeSignatureVerifier.ts implements the signature validation routine for Electron applications on Windows. It executes the following command in a new shell (process.env.ComSpec on Windows, usually C:\Windows\System32\cmd.exe):

https://github.com/electron-userland/electron-builder/blob/140e2f0eb0df79c2a46e35024e96d0563355fc89/packages/electron-updater/src/windowsExecutableCodeSignatureVerifier.ts#L35-L41

Because of the surrounding shell, a first pass by cmd.exe expands any environment variable found in command-line above.

Exploitation

This creates a situation where verifySignature() can be tricked into validating the certificate of a different file than the one that was just downloaded. If the step is successful, the malicious update will be executed even if its signature is invalid.

Impact

This attack assumes a compromised update manifest (server compromise, Man-in-the-Middle attack if fetched over HTTP, Cross-Site Scripting to point the application to a malicious updater server, etc.).

Patch

This vulnerability was patched in #​8295, by comparing the path in the output of Get-AuthenticodeSignature with the intended one. The patch is available starting from 6.3.0-alpha.6.


Release Notes

electron-userland/electron-builder (electron-updater)

v6.3.0

Compare Source

Minor Changes
Patch Changes

v6.2.1

Compare Source

Patch Changes

v6.2.0

Compare Source

Minor Changes

v6.1.9

Compare Source

Patch Changes

v6.1.8

Compare Source

Patch Changes

v6.1.7

Compare Source

Patch Changes

v6.1.6

Compare Source

Patch Changes
  • Updated dependencies [549d07b0]:
    • builder-util-runtime@​9.2.2

v6.1.5

Compare Source

Patch Changes
  • #​7767 21f3069c Thanks @​jackple! - fix: When error code is ENOENT, try to use electron.shell.openPath to run installer on Windows

v6.1.4

Compare Source

Patch Changes

v6.1.3

Compare Source

Patch Changes

v6.1.2

Compare Source

Patch Changes

v6.1.1

Compare Source

Patch Changes

v6.1.0

Compare Source

Minor Changes
Patch Changes

v6.0.4

Compare Source

Patch Changes

v6.0.3

Compare Source

Patch Changes
  • #​7524 1a134800 Thanks @​NoahAndrews! - Fixed error handling when launching updater (fixes NSIS updates when isAdminRightsRequired is incorrectly set to false)

v6.0.2

Compare Source

Patch Changes

v6.0.1

Compare Source

Patch Changes

v6.0.0

Compare Source

Major Changes
Minor Changes
Patch Changes

v5.3.0

Compare Source

Minor Changes

v5.2.4

Compare Source

Patch Changes

v5.2.3

Compare Source

Patch Changes

v5.2.2

Compare Source

Patch Changes
  • Updated dependencies [e7179b57]:
    • builder-util-runtime@​9.1.0

v5.2.1

Compare Source

Patch Changes

v5.2.0

Compare Source

Minor Changes
  • #​6907 e7f28677 Thanks @​panther7! - Add installDir property for NsisUpdater. Now is it posible change install folder from AppUpdater.

v5.1.0

Compare Source

Minor Changes
Patch Changes
  • #​6975 8279d053 Thanks @​ezekg! - Fix artifact conflicts for Keygen provider when multiple artifacts share the same filename across products.

  • Updated dependencies [adeaa347]:

    • builder-util-runtime@​9.0.3

v5.0.6

Compare Source

Patch Changes

v5.0.5

Compare Source

Patch Changes

v5.0.4

Compare Source

Patch Changes

v5.0.3

Compare Source

Patch Changes

v5.0.2

Compare Source

Patch Changes
  • 9a7ed436 - chore: updating dependency tree

  • Updated dependencies [9a7ed436]:

    • builder-util-runtime@​9.0.1

v5.0.1

Compare Source

Patch Changes

v5.0.0

Compare Source

Major Changes
Minor Changes
Patch Changes
  • #​6589 633ee5dc Thanks @​devinbinnie! - - Removed backtick escaping for Windows code signing as it is unnecessary for Powershell and can cause the script to attempt to access the wrong file
    • Updated the proxy filename to be more secure (512-bit string)
  • #​6616 86e6d150 Thanks @​mmaietta! - fix(updater): Remove checks for app-update.yml when auto-updates are not supported

  • Updated dependencies [a138a86f]:

    • builder-util-runtime@​9.0.0

v4.6.5

Patch Changes

v4.6.4

Patch Changes

v4.6.3

Patch Changes

v4.6.2

Patch Changes

v4.6.1

Patch Changes
  • Updated dependencies [54ee4e72]:
    • builder-util-runtime@​8.9.1

v4.6.0

Minor Changes
Patch Changes
  • Updated dependencies [a9453216]:
    • builder-util-runtime@​8.9.0

v4.5.2

Patch Changes

v4.5.1

Patch Changes
  • Updated dependencies [7f933d00]:
    • builder-util-runtime@​8.8.1

v4.5.0

Minor Changes
Patch Changes
  • Updated dependencies [f45110cb]:
    • builder-util-runtime@​8.8.0

v4.4.6

Patch Changes
  • a3c72b2: fix(electron-updater): workaround vite's process.env.* replacement
  • ca0e845: fix(electron-updater): null object error when MacUpdater attempts to log the server port before it is listening

v4.4.5

Patch Changes
  • a3f2cd1: fix(electron-updater): default import throws error for fs and path leading to always requiring elevation
  • ae363e5: fix: removing data from error being thrown. It's unnecessary and also unnecessarily large to be passing to the console. Resolves: #​6131

v4.4.4

Patch Changes
  • ae81dfa: fix(electron-updater): small cleanup and add more debug logging for MacUpdater to investigate #​6120

v4.4.3

Patch Changes
  • a4eae34: Synchronizing CLI and package.json versions. Updating auto-publish values + changeset generation to be more frictionless
  • Updated dependencies [a4eae34]
    • builder-util-runtime@​8.7.10

v4.4.2

Patch Changes
  • 878671d: Updating patch number as many deps were updated as parted of RenovateBot integration
  • Updated dependencies [878671d]
    • builder-util-runtime@​8.7.9

v4.4.1

Patch Changes
  • 1272afc: Initial introduction of changset config
  • Updated dependencies [1272afc]
    • builder-util-runtime@​8.7.8
Bug Fixes
  • Remove dependency on pako module, use native API instead.

Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot added the renovate PR automatically generated by renovate label Sep 25, 2024
Copy link

bundlemon bot commented Sep 25, 2024
edited
Loading

BundleMon

Unchanged files (4)
Status Path Size Limits
renderer.(hash).js
6.88MB -
vendors~renderer.(hash).js
4.7MB -
updater.js
115.28KB -
guest-api.js
40.19KB -

No change in files bundle size

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@renovate renovate bot changed the title (削除) fix(deps): update dependency electron-updater to v6 [security] (削除ここまで) (追記) fix(deps): update dependency electron-updater to v6 [security] - autoclosed (追記ここまで) Sep 25, 2024
@renovate renovate bot closed this Sep 25, 2024
@renovate renovate bot deleted the renovate/npm-electron-updater-vulnerability branch September 25, 2024 16:55
@renovate renovate bot changed the title (削除) fix(deps): update dependency electron-updater to v6 [security] - autoclosed (削除ここまで) (追記) fix(deps): update dependency electron-updater to v6 [security] (追記ここまで) Sep 26, 2024
@renovate renovate bot reopened this Sep 26, 2024
@renovate renovate bot restored the renovate/npm-electron-updater-vulnerability branch September 26, 2024 19:33
@renovate renovate bot force-pushed the renovate/npm-electron-updater-vulnerability branch from 96003aa to f578702 Compare September 26, 2024 19:34
@renovate renovate bot changed the title (削除) fix(deps): update dependency electron-updater to v6 [security] (削除ここまで) (追記) Update dependency electron-updater to v6 [SECURITY] (追記ここまで) Jan 22, 2025
@renovate renovate bot changed the title (削除) Update dependency electron-updater to v6 [SECURITY] (削除ここまで) (追記) fix(deps): update dependency electron-updater to v6 [security] (追記ここまで) Feb 10, 2025
@renovate renovate bot changed the title (削除) fix(deps): update dependency electron-updater to v6 [security] (削除ここまで) (追記) Update dependency electron-updater to v6 [SECURITY] (追記ここまで) Mar 26, 2025
@renovate renovate bot changed the title (削除) Update dependency electron-updater to v6 [SECURITY] (削除ここまで) (追記) fix(deps): update dependency electron-updater to v6 [security] (追記ここまで) Apr 3, 2025
@renovate renovate bot changed the title (削除) fix(deps): update dependency electron-updater to v6 [security] (削除ここまで) (追記) Update dependency electron-updater to v6 [SECURITY] (追記ここまで) Jun 12, 2025
@renovate renovate bot changed the title (削除) Update dependency electron-updater to v6 [SECURITY] (削除ここまで) (追記) fix(deps): update dependency electron-updater to v6 [security] (追記ここまで) Jul 10, 2025
@renovate renovate bot force-pushed the renovate/npm-electron-updater-vulnerability branch 2 times, most recently from 38ad0a6 to 8bba49e Compare August 13, 2025 15:00
@renovate renovate bot force-pushed the renovate/npm-electron-updater-vulnerability branch 2 times, most recently from ab86ac0 to 15f21f7 Compare August 20, 2025 18:28
@renovate renovate bot changed the title (削除) fix(deps): update dependency electron-updater to v6 [security] (削除ここまで) (追記) Update dependency electron-updater to v6 [SECURITY] (追記ここまで) Aug 20, 2025
@renovate renovate bot force-pushed the renovate/npm-electron-updater-vulnerability branch from 15f21f7 to d67e0a3 Compare August 31, 2025 10:08
@renovate renovate bot changed the title (削除) Update dependency electron-updater to v6 [SECURITY] (削除ここまで) (追記) fix(deps): update dependency electron-updater to v6 [security] (追記ここまで) Sep 18, 2025
@renovate renovate bot force-pushed the renovate/npm-electron-updater-vulnerability branch from d67e0a3 to c0bfde4 Compare September 25, 2025 15:29
@renovate renovate bot changed the title (削除) fix(deps): update dependency electron-updater to v6 [security] (削除ここまで) (追記) Update dependency electron-updater to v6 [SECURITY] (追記ここまで) Sep 29, 2025
@renovate renovate bot changed the title (削除) Update dependency electron-updater to v6 [SECURITY] (削除ここまで) (追記) fix(deps): update dependency electron-updater to v6 [security] (追記ここまで) Sep 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

renovate PR automatically generated by renovate

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

0 participants

AltStyle によって変換されたページ (->オリジナル) /