Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[6.x] Fix nested revealer fields #12362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
duncanmcclean wants to merge 2 commits into master
base: master
Choose a base branch
Loading
from fix-nested-revealers
Open

Conversation

Copy link
Member

@duncanmcclean duncanmcclean commented Sep 8, 2025

This pull request attempts to fix an issue where Revealer fields weren't working in nested fieldtypes like Bard & Replicator.

This was happening because the revealerValues object we're getting from the Container and passing to ShowField looks like this:

{
 replicator.0.revealer: true
}

However, when the field condition validator attempts to get the field's value, it fails, because it's trying to find a value using the revealer's field handle, not its "full dotted path".

This PR fixes it by only passing the "relative" revealer values to ShowField and flattening the keys to just the field handles.

Fixes #12099.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[6.x] Revealer field conditions not working with "Toggle" UI mode

1 participant

AltStyle によって変換されたページ (->オリジナル) /