Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[6.x] Support more video providers, including Cloudflare Stream #11871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
edalzell wants to merge 26 commits into statamic:master
base: master
Choose a base branch
Loading
from edalzell:feature/add-cf-to-video-fieldtype

Conversation

Copy link
Contributor

@edalzell edalzell commented Jun 13, 2025

Copy link
Contributor

Might be worthwhile doing something similar to what I did with the embera tag - https://github.com/godismyjudge95/statamic-embera

Embera is a oembed client that takes in a video url and spits out an iframe. It has a decent number of video providers supported - https://github.com/mpratt/Embera/blob/master/doc/02-providers.md

edalzell reacted with thumbs up emoji

Copy link
Contributor Author

Might be worthwhile doing something similar to what I did with the embera tag - godismyjudge95/statamic-embera

This is a really nice idea. I'll chat w/ the team on how they'd like to approach, as it's another dependency.

godismyjudge95 reacted with thumbs up emoji

@duncanmcclean duncanmcclean changed the base branch from ui to master June 30, 2025 18:42
Copy link
Contributor Author

edalzell commented Jul 1, 2025

  • 3 fields - url for pasting, dropdown for provider, video id
  • if you paste into the url, we'll extract the id and populate provider/id
  • save the provider/id

for augmenting maybe...

  • have a Video class with provider and id
  • the Video class would know how to get the regular and embed urls
  • __toString could output the non-embed url so {{ video_field }} on its own would continue to work
  • the embed_url modifier could handle a Video instance, so it could get the embed url from that

for backwards compat...

  • if your field has a url, it doesnt get augmented to a Video instance. it stays as a string.

@edalzell edalzell marked this pull request as ready for review July 9, 2025 22:13
Copy link
Member

@duncanmcclean duncanmcclean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like some of the tests are failing. Are you able to take a look?

Copy link
Contributor Author

It looks like some of the tests are failing. Are you able to take a look?

Done

duncanmcclean reacted with thumbs up emoji

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@duncanmcclean duncanmcclean duncanmcclean requested changes

@jasonvarga jasonvarga Awaiting requested review from jasonvarga

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /