-
-
Notifications
You must be signed in to change notification settings - Fork 587
[5.x] Allow stache stores to be excluded from warming and clearing #11830
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.x] Allow stache stores to be excluded from warming and clearing #11830
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This approach seems to cause issues when you're using split configs (eg. storing collections in the database, but keeping entries as flat files). 🤔
Also, when I try to import a taxonomy on the Eloquent side, it fails due to it hitting the removed taxonomies store.
Going to leave this open until @jasonvarga is back in case he has any ideas.
Yep, maybe the better approach is to provide a way to exclude stores from warming, as that solves the actual problem, rather than a non-stache driver removing stache stores. Anyway, one to discuss.
[edit]: I've updated this PR to take the excluding approach.
Uh oh!
There was an error while loading. Please reload this page.
When using the eloquent driver with split configurations and running
stache:warm, stache stores that aren't file driven are still registered and warmed. Most of the time this is not noticeable as theres no data, but when you have lots of entries with terms it creates the associations and this is a big bottleneck.This PR adds the ability to exclude registered stache stores from warming and clearing operations, which allows the eloquent driver to ensure they are excluded.
See: statamic/eloquent-driver#433