-
-
Notifications
You must be signed in to change notification settings - Fork 587
[5.x] Fix navigation edit form state issues #11732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes issues where the meta field state for the Navigation EditForm was incorrect when closed. It also resolves related errors when using Grid, Replicator and Relationship fieldtypes.
Changing this into a draft ... there's still an issue with the fix when changing values back and forth. 🥲
Would be great to get this one solved soon. I'm working on a mega-menu for a client and Replicators or Grids within nav blueprints seems like the only reliable way to do it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10630 & #11588
This commit fixes issues where the meta field state for the Navigation EditForm was incorrect when closed. It also resolves related errors / warnings when using Grid, Replicator and Relationship fieldtypes.