-
-
Notifications
You must be signed in to change notification settings - Fork 586
[5.x] Fix a bug where Saving entry would move it to the last place in the parent hierarchy #11687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
modrictin
wants to merge
2
commits into
statamic:5.x
from
isarphilipp:fix-entry-saving-on-the-last-place-of-parent
Open
[5.x] Fix a bug where Saving entry would move it to the last place in the parent hierarchy #11687
modrictin
wants to merge
2
commits into
statamic:5.x
from
isarphilipp:fix-entry-saving-on-the-last-place-of-parent
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...the parent hierarchy
@duncanmcclean
duncanmcclean
changed the title
(削除) Fix: Fix a bug where Saving entry would move it to the last place in ... (削除ここまで)
(追記) [5.x] Fix a bug where Saving entry would move it to the last place in ... (追記ここまで)
Apr 10, 2025
@duncanmcclean
duncanmcclean
changed the title
(削除) [5.x] Fix a bug where Saving entry would move it to the last place in ... (削除ここまで)
(追記) [5.x] Fix a bug where Saving entry would move it to the last place in the parent hierarchy (追記ここまで)
May 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey team! 👋
I found a bug related to structured, orderable collections.
🔍 Issue:
Whenever you save an entry that already has a parent in the structure, it’s always moved to the bottom of the parent’s hierarchy, even if its position shouldn’t change.
🛠️ Fix:
I’ve added a check to prevent reordering if the entry is already under the same parent. This preserves the current structure unless a move is truly needed.
🧪 To reproduce:
1. Create an orderable collection with structure.
2. Add a few entries — some nested under others.
3. Edit and save a nested entry.
👉 You’ll see it gets pushed to the bottom of its parent’s children.
I’ve implemented the fix in my own codebase. If it’s helpful for core, happy to contribute it.
Let me know if you’d like me to adjust anything or improve the approach — happy to collaborate! 🙌
Thanks! 🚀