Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[5.x] Fix a bug where Saving entry would move it to the last place in the parent hierarchy #11687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
modrictin wants to merge 2 commits into statamic:5.x
base: 5.x
Choose a base branch
Loading
from isarphilipp:fix-entry-saving-on-the-last-place-of-parent

Conversation

Copy link
Contributor

@modrictin modrictin commented Apr 10, 2025

Hey team! 👋

I found a bug related to structured, orderable collections.

🔍 Issue:
Whenever you save an entry that already has a parent in the structure, it’s always moved to the bottom of the parent’s hierarchy, even if its position shouldn’t change.

🛠️ Fix:
I’ve added a check to prevent reordering if the entry is already under the same parent. This preserves the current structure unless a move is truly needed.

🧪 To reproduce:
1. Create an orderable collection with structure.
2. Add a few entries — some nested under others.
3. Edit and save a nested entry.
👉 You’ll see it gets pushed to the bottom of its parent’s children.

I’ve implemented the fix in my own codebase. If it’s helpful for core, happy to contribute it.
Let me know if you’d like me to adjust anything or improve the approach — happy to collaborate! 🙌

Thanks! 🚀

martyf reacted with heart emoji
@duncanmcclean duncanmcclean changed the title (削除) Fix: Fix a bug where Saving entry would move it to the last place in ... (削除ここまで) (追記) [5.x] Fix a bug where Saving entry would move it to the last place in ... (追記ここまで) Apr 10, 2025
@duncanmcclean duncanmcclean changed the title (削除) [5.x] Fix a bug where Saving entry would move it to the last place in ... (削除ここまで) (追記) [5.x] Fix a bug where Saving entry would move it to the last place in the parent hierarchy (追記ここまで) May 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /