Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix tvOS CI #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bbrk24 wants to merge 3 commits into stackotter:main
base: main
Choose a base branch
Loading
from bbrk24:fix-tvOS-CI
Open

Fix tvOS CI #224

bbrk24 wants to merge 3 commits into stackotter:main from bbrk24:fix-tvOS-CI

Conversation

Copy link
Contributor

@bbrk24 bbrk24 commented Oct 16, 2025
edited
Loading

Fixes #223

Turns out the set -e call in the script was almost immediately followed by set +e, so I had to move it further down to make the tests fail correctly. Then I updated the code so now it actually builds on tvOS.

Copy link
Contributor Author

bbrk24 commented Oct 16, 2025
edited
Loading

Looks like about six hours ago, a commit was pushed to https://github.com/thebrowsercompany/swift-windowsfoundation that means it can no longer be pulled in by xcodebuild. (Not sure why it's succeeding on Linux; you'd think xcodebuild and SPM would resolve dependencies the same way.) Sometime thereafter, the repository was archived, so we shouldn't expect an update to come and fix it. I can't point it at an older commit because one of our dependencies also points at main, so SPM will complain about the mismatched commits.

@bbrk24 bbrk24 marked this pull request as ready for review October 18, 2025 00:35
Copy link
Owner

@stackotter stackotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this. I've just annotated the changes with one small question, but all looks great other than that.

) {
let textEditorWidget = textEditor as! TextEditorWidget

textEditorWidget.child.isEditable = environment.isEnabled
Copy link
Owner

@stackotter stackotter Oct 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would we have to still set .child.isEditable somewhere? This change seems like it'd break something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stackotter stackotter stackotter requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Apple TV workflow step is failing, but reporting a success

AltStyle によって変換されたページ (->オリジナル) /