-
-
Notifications
You must be signed in to change notification settings - Fork 58
Fix tvOS CI #224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tvOS CI #224
Conversation
Looks like about six hours ago, a commit was pushed to https://github.com/thebrowsercompany/swift-windowsfoundation that means it can no longer be pulled in by xcodebuild. (Not sure why it's succeeding on Linux; you'd think xcodebuild and SPM would resolve dependencies the same way.) Sometime thereafter, the repository was archived, so we shouldn't expect an update to come and fix it. I can't point it at an older commit because one of our dependencies also points at main
, so SPM will complain about the mismatched commits.
9db850d
to
af6bde0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this. I've just annotated the changes with one small question, but all looks great other than that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would we have to still set .child.isEditable
somewhere? This change seems like it'd break something.
Uh oh!
There was an error while loading. Please reload this page.
Fixes #223
Turns out the
set -e
call in the script was almost immediately followed byset +e
, so I had to move it further down to make the tests fail correctly. Then I updated the code so now it actually builds on tvOS.