-
Notifications
You must be signed in to change notification settings - Fork 71
Init mocks on Docker startup #222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
danielpoonwj
wants to merge
2
commits into
smocker-dev:main
from
danielpoonwj:docker-startup-init-mocks
Open
Init mocks on Docker startup #222
danielpoonwj
wants to merge
2
commits into
smocker-dev:main
from
danielpoonwj:docker-startup-init-mocks
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steveoh
commented
Feb 7, 2023
This looks great. Any word on a review and merge status?
Any updates on this or why it isn't considered?
TomasLukl
commented
Sep 14, 2024
This would really be useful. Any updates on this? Thank you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
There are a few active discussions on being able to initialize mocks or configure Smocker on startup (#217, #214) and this is another proposed approach.
This only applies to Docker-based workflows, but the implementation is more straightforward without touching the actual core codebase.
Approach
The main idea is using an Entrypoint script to start the server process in the background, run some configuration code, then restore the process to the foreground. This pattern is described in the official Docker docs. It's also used in practice in postgres, mysql, localstack etc.
Note:
bash
needs to be used instead of the default bourne shell in alpine because of some issues when attempting to work with background jobs. If you change the Entrypoint shebang to#!/bin/sh
, there will be an error.