-
Notifications
You must be signed in to change notification settings - Fork 982
fix(web): Remove KeyboardListener causing extra Tab stop in focus traversal #2648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The web-specific KeyboardListener was creating an unnecessary focus node that required users to press Tab one extra time to reach the editor. This change improves keyboard navigation efficiency by removing the workaround that is no longer needed.
Removes unnecessary variable assignment. Simplifies the conditional return statement within the editor widget for improved readability and efficiency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the web-specific
KeyboardListenerthat was causing inefficient Tab navigation focus on Flutter Web.Current behavior: On Flutter Web, users need an extra Tab press to reach the Quill editor because a
KeyboardListenerwith aFocusNodecreates an additional focus stop in the tab order, making keyboard navigation inefficient.New behavior: Tab navigation works efficiently across all platforms, allowing users to focus the editor directly without unnecessary extra tab stops.
Motivation: The original
KeyboardListenerwas added as a workaround for issue #304 to prevent key event interference with parent widgets likeSingleChildScrollView. However, the original issue could not be reproduced in current Flutter/Quill versions, while the workaround was creating an unnecessary focus traversal step. This change prioritizes efficient keyboard navigation and code simplification.Alternative solution: If the original issue #304 resurfaces, an alternative approach would be to add
skipTraversal: trueto theFocusNodeinstead of removing the entireKeyboardListener.Type of Change