Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Feat(BREAKING CHANGES): Add EmbedContext argument in buildWidgetSpan #2615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pamafe1976 wants to merge 2 commits into singerdmx:master
base: master
Choose a base branch
Loading
from pamafe1976:master

Conversation

Copy link

@pamafe1976 pamafe1976 commented Jul 17, 2025
edited
Loading

Description

adds EmbedContext as argument to buildWidgetSpan

Related Issues

Related #2614

Type of Change

  • Feature: New functionality without breaking existing features.
  • 🛠️ Bug fix: Resolves an issue without altering current behavior.
  • 🧹 Refactor: Code reorganization, no behavior change.
  • Breaking: Alters existing functionality and requires updates.
  • 🧪 Tests: New or modified tests
  • 📝 Documentation: Updates or additions to documentation.
  • 🗑️ Chore: Routine tasks, or maintenance.
  • Build configuration change: Build/configuration changes.

bool get expanded => true;

WidgetSpan buildWidgetSpan(Widget widget) {
WidgetSpan buildWidgetSpan(Widget widget, EmbedContext embedContext) {
Copy link
Collaborator

@EchoEllet EchoEllet Jul 22, 2025
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a breaking change. Clients need to update their code to build.

@CatHood0 CatHood0 changed the title (削除) Add EmbedContext argument in buildWidgetSpan (削除ここまで) (追記) Feat(BREAKING CHANGES): Add EmbedContext argument in buildWidgetSpan (追記ここまで) Aug 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@EchoEllet EchoEllet EchoEllet left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /