Skip to content

Fix: embedded image replaced by plain text unicode when adding Chinese text #2505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open

mchangtian wants to merge 2 commits into singerdmx:master

from mchangtian:fix-bug-issue#2503

Open

Fix: embedded image replaced by plain text unicode when adding Chinese text #2505

Changes from all commits

Commits

Show all changes

Select commit Hold shift + click to select a range

Dynamically calculate cursor position to resolve misalignment issues ...

chore: remove duplicated comment (nit)

EchoEllet Mar 10, 2025

File filter

Filter by extension

Conversations

Jump to

Jump to file

Failed to load files.

Loading

Diff view

Diff view

8 changes: 6 additions & 2 deletions lib/src/editor/raw_editor/raw_editor_state_text_input_client_mixin.dart

Show comments View file Open in desktop

Original file line number	Diff line number	Diff line change
Expand Up		@@ -222,8 +222,12 @@ mixin RawEditorStateTextInputClientMixin on EditorState
		_lastKnownRemoteTextEditingValue = value;
		final oldText = effectiveLastKnownValue.text;
		final text = value.text;
	final cursorPosition = value.selection.extentOffset;
	final diff = getDiff(oldText, text, cursorPosition);

	// Dynamically calculate cursor position to resolve misalignment issues when inputting Chinese with Sogou Pinyin.
	final effectiveCursorPosition = value.isComposingRangeValid
EchoEllet marked this conversation as resolved. Show resolved Hide resolved
	? value.composing.end
	: value.selection.extentOffset;
	final diff = getDiff(oldText, text, effectiveCursorPosition);
		if (diff.deleted.isEmpty && diff.inserted.isEmpty) {
		widget.controller.updateSelection(value.selection, ChangeSource.local);
		} else {
Expand Down

Loading